order rule: add pathGroups option to add support to order by paths

[Mairu]

Well there are multiple issues and pull requests open regarding the ordering of groups by paths.
Because I saw that the proposed approach in #795 was "accepted" I implemented it this way.

But if @ljharb has changed his mind in the mean time and would prefer something like custom groups as proposed in #1015 (comment) I can also rework this.

[coveralls]

Coverage increased (+2.6%) to 97.814% when pulling 5c46fae on Mairu:pathGroups into 58b41c2 on benmosher:master.

[coveralls]

Coverage increased (+0.1%) to 96.405% when pulling 0426f16 on Mairu:pathGroups into 99b3fbf on benmosher:master.

[Mairu]

Anything else needed for this to be merged? @ljharb

[fundlg]

+1, need this feature

[osdiab]

Any reason this has stalled? Would love to use this @ljharb

[zaqqaz]

Any reason this has stalled? Would love to use this @ljharb

@benmosher, @ljharb ⬆️

[ljharb]

LGTM overall

[osdiab]

ping on if this is gonna get merged...

[osdiab]

@benmosher, @ljharb ⬆️

[oliverdolgener]

I'd really like to see this getting merged :D

[osdiab]

I was wondering if I was misusing this new rule.

With this this code, I want it to behave as so:

// BEFORE FIX
import { testHelper } from "__tests__/helpers";
import { RecurringStatus } from "@my.company/common/es6/entity/types";
import { ChartistGraph } from "@app/components/common/ChartistGraph";
import { ILineChartOptions } from "chartist";

// AFTER FIX
// this is external, so before all this package's imports
import { ILineChartOptions } from "chartist";

// this is external, but monorepo package, so put it after normal external
import { RecurringStatus } from "@my.company/common/es6/entity/types";

// this is internal, so mixed with anything else internal
import { ChartistGraph } from "@app/components/common/ChartistGraph";

// this is internal but secondary, so after other internal code
import { testHelper } from "__tests__/helpers";

I configured my import/order like so:

        "pathGroups": [
          {
            "pattern": "@app/**",
            "group": "internal"
          },
          {
            "pattern": "__tests__/**",
            "group": "internal",
            "position": "after"
          },
          {
            "pattern": "@my.company/**",
            "group": "external",
            "position": "after"
          }
        ],

But this doesn't mark my BEFORE FIX code as an error at all :P not sure why.

[osdiab]

I edited the above for my second try

[ljharb]

Please file a new issue so we can track it properly :-)

[jgabriele]

Thank you ❤️!