Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] no-unused-modules: handle ClassDeclaration #1371

Merged
merged 1 commit into from
May 30, 2019
Merged

[fix] no-unused-modules: handle ClassDeclaration #1371

merged 1 commit into from
May 30, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented May 29, 2019

Fixes #1368

This commit finds all codes related to FunctionDeclaration, and double it up with ClassDeclaration.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.803% when pulling 8b55e8f on golopot:no-unused-modules-handles-class into ca4bf95 on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.803% when pulling 8b55e8f on golopot:no-unused-modules-handles-class into ca4bf95 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.803% when pulling 8b55e8f on golopot:no-unused-modules-handles-class into ca4bf95 on benmosher:master.

@ljharb ljharb added the bug label May 30, 2019
@ljharb ljharb merged commit 0e719c3 into import-js:master May 30, 2019
@golopot golopot deleted the no-unused-modules-handles-class branch September 7, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-unused-modules does not work with export class
3 participants
@golopot @coveralls @ljharb