no-cycle: consider deep require calls

[benmosher]

Just making a note to come back to no-cycle and capture require calls in ExportMap to check for cycles in addition to exploring import statements.

[yelworc]

I'd appreciate this a lot; just fiddled with the no-cycle rule for a while, only to realize that it just doesn't work for good old regular Node.js projects (it does say so in the docs, but it's not quite obvious).

Just had a quick look at ExportMap myself, but this doesn't strike me as an easy first contribution :)

[soryy708]

There's eslint-plugin-dependencies that used to work with require, but it seems abandoned.
Perhaps it can be scavenged?

[soryy708]

Related: #971

[soryy708]

I'm writing some tests for this. How do you expect this to work with regards to the commonjs option? Should it look for dependency cycles in requires only if commonjs: true?

(Link to documentation)

[soryy708]

So this is sort-of a revert of #797 ?

[ljharb]

sort of, just reverted behind the option :-) (and avoiding the crash)