-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): remove is-core-module
dependency
#295
Conversation
🦋 Changeset detectedLatest commit: 96951da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc @JounQin
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/is-core-module@2.2.2, npm/is-core-module@2.13.1 |
CI is broken due to linting. |
Node.js from v6.13.0, v8.10.0, v9.3.0 includes `module.builtinModules` which we can use to natively check if some module belongs to Node.js core or not. This drops not one, but _three_ dependencies, removing 70 KB of bloat: https://npmgraph.js.org/?q=is-core-module
Co-authored-by: Grigory <grigory.orlov.set@gmail.com>
Heads up that this will break for |
Node.js from v6.13.0, v8.10.0, v9.3.0 includes
module.builtinModules
which we can use to natively check if some module belongs to Node.js core or not.This drops not one, but three dependencies, removing 70 KB of bloat: https://npmgraph.js.org/?q=is-core-module