Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect "engines" declaration - not actually working with node 12 #192

Closed
Rialgar opened this issue Oct 19, 2022 · 1 comment · Fixed by #193
Closed

Incorrect "engines" declaration - not actually working with node 12 #192

Rialgar opened this issue Oct 19, 2022 · 1 comment · Fixed by #193

Comments

@Rialgar
Copy link
Contributor

Rialgar commented Oct 19, 2022

Since you are importing "node:fs" and "node:path" you are requiring node.js 14.18, 16.0, or later since your version 3.0.0. Also synckit in the version you use requires node 14. However, your engines field still includes "^12.20.0".

I can file a PR, if you want, but the issue is that this is already wrong for your existing published version 3.0.0 and newer, so you may want to consider re-publishing those as well, which is a little more involved than a simple PR.

@JounQin
Copy link
Collaborator

JounQin commented Oct 20, 2022

You're right here, I was using ^12.20.0 before because I was thinking about ESM, but this plugin only works with commonjs, actually.

https://2ality.com/2021/12/node-protocol-imports.html#support-for-node%3A-imports

We've alreay using "node:fs" and "node:path" since 3.0, so I think it's OK to just correct the engine field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants