fix: fix prefix-only modules not marked as builtin

wojtekmaj · wojtekmaj · commit a63eb46b5cee · 2024-07-17T01:06:41.000+02:00
Following @ljharb's feedback in #295 (comment), a different version of isBuiltin function has been implemented.
diff --git a/.changeset/red-giraffes-sleep.md b/.changeset/red-giraffes-sleep.md
@@ -0,0 +1,5 @@
+---
+'eslint-import-resolver-typescript': patch
+---
+
+fix: fix prefix-only Node.js modules not correctly recognized as builtin, a regression in v3.6.2
diff --git a/src/index.ts b/src/index.ts
@@ -125,7 +125,7 @@ const digestHashObject = (value: object | null | undefined) =>
  * versions of Node.js, we can use module.isBuiltin instead of this function.
  */
 function isBuiltin(moduleName: string) {
-  return builtinModules.includes(moduleName.replace(/^node:/, ''))
+  return moduleName.startsWith('node:') || builtinModules.includes(moduleName)
 }
 
 /**

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'eslint-import-resolver-typescript': patch
 +---
++
 +fix: fix prefix-only Node.js modules not correctly recognized as builtin, a regression in v3.6.2
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ const digestHashObject = (value: object \| null \| undefined) =>`
`125`	`125`	`* versions of Node.js, we can use module.isBuiltin instead of this function.`
`126`	`126`	`*/`
`127`	`127`	`function isBuiltin(moduleName: string) {`
`128`		`- return builtinModules.includes(moduleName.replace(/^node:/, ''))`
	`128`	`+ return moduleName.startsWith('node:') \|\| builtinModules.includes(moduleName)`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`/**`