Feature/index #17
Merged
Feature/index #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the wizard’s logic from the tasks service into a dedicated wizard service and controller, while also adding indexing functionality after resource creation/updating. Key changes include:
- Introducing new wizard endpoints (collect, fetch, callback) and corresponding service methods.
- Removing the task-related wizard logic from TasksService and its controllers.
- Updating ResourcesService to trigger index creation and deletion on resource create/update/delete.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/wizard/wizard.service.ts | Implements new wizard functions (collect, fetch, taskDoneCallback). |
| src/wizard/wizard.module.ts | Registers wizard components and related dependencies. |
| src/wizard/wizard.controller.ts | Exposes the public wizard API endpoint for collecting data. |
| src/wizard/internal.wizard.controller.ts | Exposes internal endpoints for task fetching and callback handling. |
| src/tasks/tasks.service.ts | Removes obsolete wizard-related functions from tasks service. |
| src/tasks/tasks.module.ts | Cleans up controller imports by removing internal tasks controller. |
| src/resources/resources.service.ts | Adds indexing call after resource creation/updating and deletes index on deletion. |
| src/resources/resources.module.ts | Includes Task entity for index operations. |
| src/app/app.module.ts | Imports the new WizardModule. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.