-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/collect #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/collect #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new "collect" feature and refactors task handling while renaming endpoints and controllers to improve consistency. Key changes include the implementation of a new collect method in the tasks service, the migration and renaming of internal task controllers, and several updates across authentication, mail, and namespace modules to support the new functionality.
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/each.ts | Minor formatting update with a trailing comma in the callback. |
| src/tasks/tasks.service.ts | Added new collect, taskDoneCallback, raw SQL query for task fetching, and removed deprecated callback. |
| src/tasks/tasks.module.ts | Updated imports to reference renamed internal tasks controller and added ResourcesModule. |
| src/tasks/tasks.entity.ts | Changed default priority and removed concurrencyThreshold column. |
| src/tasks/tasks.controller.ts | Added new /collect endpoint for handling collect requests. |
| src/tasks/internal.tasks.controller.ts | Introduced new internal controller for tasks callbacks and fetching. |
| src/tasks/internal-tasks.controller.ts | Removed legacy controller. |
| src/tasks/dto/*.ts | Added new DTOs for task callback and collect request validation. |
| src/resources/dto/update-resource.dto.ts | Updated validation imports. |
| src/namespaces/*.ts | Added findByName service method and new columns in the namespace entity. |
| src/mail/mail.service.ts | Renamed email methods and updated email templates. |
| src/auth/*.ts | Added internal auth controller and renamed endpoints, updating signup flows. |
| compose.yaml | Updated port mapping to use an environment variable. |
Files not reviewed (1)
- .env.example: Language not supported
Comments suppressed due to low confidence (2)
src/tasks/tasks.service.ts:59
- [nitpick] Using the property name 'function' may be confusing due to its reserved status in JavaScript. Consider renaming it to a more descriptive name such as 'taskType' to improve clarity.
function: 'collect',
src/tasks/tasks.module.ts:6
- [nitpick] The renamed file 'internal.tasks.controller.ts' deviates from the previous kebab-case convention ('internal-tasks.controller.ts'). Please ensure that the file naming is consistent with the project's established practices.
import { InternalTasksController } from 'src/tasks/internal.tasks.controller';
hewenguang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Route under
auth.controller.tschanged but not verified.