Skip to content

fix(login): fixed login error #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

fix(login): fixed login error #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/auth/auth.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { UserInvitationDto } from './dto/invitation.dto';
import { SignUpPayloadDto } from './dto/signup-payload.dto';
import { LoginPayloadDto } from './dto/login-payload.dto';
import { NamespaceRole } from 'omniboxd/namespaces/entities/namespace-member.entity';
import { isEmail } from 'class-validator';

@Injectable()
export class AuthService {
Expand All @@ -40,13 +41,15 @@ export class AuthService {
async verify(email: string, password: string): Promise<any> {
const user = await this.userService.verify(email, password);
if (!user) {
const userUseEmail = await this.userService.findByEmail(email);
if (userUseEmail) {
throw new ForbiddenException('Wrong password, please check');
if (isEmail(email)) {
const userUseEmail = await this.userService.findByEmail(email);
if (!userUseEmail) {
throw new ForbiddenException(
'No account found for the provided email. Please register first.',
);
}
}
throw new ForbiddenException(
'No account found for the provided email. Please register first.',
);
throw new ForbiddenException('Wrong password, please check');
}
return {
id: user.id,
Expand Down