Bumped min PHP version to 8.3

[MekDrop]

Resolves #30

Summary by CodeRabbit

• Chores
  • Updated PHP version support to 8.3 and above.
  • Increased minimum required Symfony Console version to 7.
  • Improved type safety and modernized code with explicit type hints and typed properties.
  • Updated GitHub Actions workflow to test only PHP 8.3 and 8.4.
• Tests
  • Enhanced test code with typed properties and updated method signatures for clarity.

[coderabbitai]

Walkthrough

The changes update the minimum supported PHP version to 8.3 in both the Composer configuration and the GitHub Actions workflow. Symfony Console dependency is bumped to version 7. The codebase and tests are modernized with typed properties and method signatures, and the workflow is streamlined to test only PHP 8.3 and 8.4.

Changes

File(s)	Change Summary
.github/workflows/on_pull_request.yml	Updated workflow to test only PHP 8.3 and 8.4, upgraded setup-php action, minor whitespace cleanup.
composer.json	Changed PHP requirement to "^8.3", updated Symfony Console dependency to "^7".
src/OutputDecorator.php	Added typed properties and method signatures, used constructor property promotion, removed debug/commented code.
tests/OutputDecoratorTest.php	Added typed properties, updated method signatures, changed helper method visibility, simplified argument unpacking.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Composer
    participant CI Workflow

    Developer->>Composer: Set PHP requirement to ^8.3, Symfony Console ^7
    Developer->>CI Workflow: Update workflow to test PHP 8.3/8.4 only
    CI Workflow->>Composer: Install dependencies (PHP 8.3+)
    CI Workflow->>CI Workflow: Run tests with modernized codebase

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Bump PHP to min 8.3 (#30)	✅

Possibly related issues

• Bump min PHP to 8.3 object-errors#53: Also requests bumping PHP minimum to 8.3, which matches these changes.
• Bump to min PHP 8.3 extension-info-contracts#48: Seeks PHP minimum 8.3, directly related.
• Bump min PHP to 8.3 queue-interop-connection-factory-helper#53: Wants PHP minimum 8.3, matches this update.
• Bump PHP to min 8.3 editor-contracts#45: Requests PHP minimum 8.3, directly relevant.
• Bump PHP to min 8.3 smarty-image#38: PHP minimum 8.3 bump, aligns with this PR.
• Bump to min PHP 8.3 smarty-includeq#33: Also about raising PHP minimum to 8.3.
• Bump PHP to min 8.3 #30: Same PHP 8.3 bump objective.
• Bump PHP to min 8.3 extensions-setup-contracts#27: Requests PHP minimum 8.3, matches.
• Bump PHP to min 8.3 smarty-db-resource#38: Bumps PHP to 8.3, aligns.
• Bump PHP to min 8.3 smarty-xo#32: Wants PHP minimum 8.3, matches.

Poem

The code now leaps to PHP eight-point-three,
With Symfony seven, as modern as can be!
Workflows trimmed, the tests all run,
Typed and tidy, the update’s done.
🐇✨
From burrow to branch, we’re hopping ahead—
Only the freshest carrots for this codebase bed!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 phpcs (3.7.2)

src/OutputDecorator.php

tests/OutputDecoratorTest.php

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8014cc5 and b1e5211.

📒 Files selected for processing (4)

• .github/workflows/on_pull_request.yml (3 hunks)
• composer.json (1 hunks)
• src/OutputDecorator.php (5 hunks)
• tests/OutputDecoratorTest.php (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

tests/OutputDecoratorTest.php (1)

src/OutputDecorator.php (1)

• OutputDecorator (13-227)

🔇 Additional comments (10)

composer.json (1)

6-7: LGTM! PHP version and Symfony Console dependency updates align with PR objectives.

The dependency updates are consistent - Symfony Console v7 requires PHP 8.2+ which aligns well with the new PHP 8.3+ requirement.

Please verify the compatibility and stability of these dependency versions:

#!/bin/bash
# Description: Verify Symfony Console v7 stability and PHP 8.3+ compatibility

# Check Symfony Console v7 latest stable version
curl -s https://packagist.org/packages/symfony/console.json | jq '.package.versions | keys_unsorted | map(select(test("^7\\."))) | .[0]'

# Check PHP 8.3 compatibility with Symfony Console v7
curl -s https://packagist.org/packages/symfony/console.json | jq '.package.versions | to_entries | map(select(.key | test("^7\\.0"))) | .[0].value.require.php // "Not specified"'

.github/workflows/on_pull_request.yml (2)

16-17: LGTM! PHP test matrix correctly updated to match new minimum requirements.

Testing only PHP 8.3 and 8.4 aligns perfectly with the new minimum PHP version requirement of 8.3 set in composer.json.

---

25-25: Good practice: Fixed version for setup-php action.

Using shivammathur/setup-php@v2 instead of @master improves build reproducibility and stability.

tests/OutputDecoratorTest.php (3)

10-11: LGTM! Typed properties modernize the test class appropriately.

The typed property declarations align well with the PHP 8.3+ requirement and improve type safety.

---

90-96: Excellent modernization of method implementation.

The changes improve the code in multiple ways:

• Making the method private provides better encapsulation
• Using argument unpacking (...$args) is more readable than call_user_func_array
• The array spread syntax (...$params) is cleaner

---

104-104: Good type safety improvement with nullable parameter types.

Adding ?string type hints to the $shouldReturn parameters enhances type safety while maintaining the existing default behavior.

Also applies to: 126-126, 145-145

src/OutputDecorator.php (4)

20-20: LGTM! Typed property declaration improves type safety.

The explicit int type for the $indent property is appropriate for PHP 8.3+ and enhances code clarity.

---

29-32: Excellent use of constructor property promotion with readonly.

This modern PHP 8.0+ syntax is perfect for PHP 8.3+ requirement and provides immutability for the decorated output instance.

---

90-92: Good code cleanup and simplification.

Removing the commented debug code and simplifying the method call improves readability while maintaining functionality.

---

81-81: Verify method signatures match Symfony Console v7 OutputInterface.

The modernized method signatures with union types and explicit return types look good, but please ensure they're compatible with Symfony Console v7's OutputInterface.

#!/bin/bash
# Description: Verify OutputInterface method signatures in Symfony Console v7

# Find OutputInterface class and check method signatures
ast-grep --pattern 'interface OutputInterface {
  $$$
  public function write($$$): $$$;
  $$$
  public function writeln($$$): $$$;
  $$$
  public function setVerbosity($$$): $$$;
  $$$
  public function setDecorated($$$): $$$;
  $$$
}'

Also applies to: 141-141, 149-149, 197-197

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.