- 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
Solves #34: Bump PHP to min 8.3 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| WalkthroughThe changes update project requirements and testing configurations to target PHP 8.3 and 8.4 exclusively. The minimum PHP version in dependencies is raised, the PHP version matrix for CI workflows is updated, and the PHPUnit code coverage reporting configuration is removed. Changes
 Possibly related issues
 Poem
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit: 
 SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
 Other keywords and placeholders
 CodeRabbit Configuration File ( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
- .github/workflows/on-pull-request.yml(1 hunks)
- composer.json(1 hunks)
- phpunit.xml(0 hunks)
💤 Files with no reviewable changes (1)
- phpunit.xml
🔇 Additional comments (2)
composer.json (1)
7-7: Verify compatibility ofsilinternational/php-envv3.3
The bump from^2.1to^3.3is a major upgrade—please confirm there are no breaking changes in the API that your code relies on..github/workflows/on-pull-request.yml (1)
15-16: Align CI matrix with supported PHP versions
Limiting tests to PHP 8.3 and 8.4 matches the new minimum, but please verify thatshivammathur/setup-php@v2fully supports PHP 8.4 (it may still be in preview).
| "silinternational/php-env": "^2.1", | ||
| "php": ">=7.2" | ||
| "silinternational/php-env": "^3.3", | ||
| "php": ">=8.3" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update PHPUnit to support PHP >=8.3
phpunit/phpunit:^8 does not support PHP 8.3+. You’ll need to bump to PHPUnit ^9.5 or higher to keep tests running under the new minimum PHP version:
 "require-dev": {
-    "phpunit/phpunit": "^8",
+    "phpunit/phpunit": "^9.5",
     "fakerphp/faker": "^1.19"
 }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "php": ">=8.3" | |
| "require-dev": { | |
| "phpunit/phpunit": "^9.5", | |
| "fakerphp/faker": "^1.19" | |
| } | 
🤖 Prompt for AI Agents
In composer.json at line 8, the PHPUnit version constraint is incompatible with
PHP 8.3 or higher. Update the PHPUnit dependency version to ^9.5 or higher to
ensure compatibility with PHP 8.3 and keep tests running correctly.
Summary by CodeRabbit