Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/on_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,16 @@ jobs:
max-parallel: 3
matrix:
composer:
- 1
- 2
php:
- 7.1
- 7.2
- 7.3
- 7.4
- 8.0
- 8.1
- 8.2
- 8.3
- 8.4
name: Test - php:${{ matrix.php }}; composer:${{ matrix.composer }}
steps:
- name: Checkout
uses: actions/checkout@v4.2.2
- name: Install PHP
uses: shivammathur/setup-php@master
uses: shivammathur/setup-php@2.34.1
with:
php-version: ${{ matrix.php }}
extensions: curl, gd, pdo_mysql, json, mbstring, pcre, session
Expand Down
3 changes: 1 addition & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
}
},
"require": {
"symfony/polyfill-php80": "^1.23",
"php": ">=7.1"
"php": ">=8.3"
}
}
3 changes: 1 addition & 2 deletions src/Factory/EditorFactoryInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Imponeer\Contracts\Editor\Factory;

use Imponeer\Contracts\Editor\Adapter\EditorAdapterInterface;
use Imponeer\Contracts\Editor\EditorInterface;
use Imponeer\Contracts\Editor\Exceptions\IncompatibleEditorException;
use Imponeer\Contracts\Editor\Info\EditorInfoInterface;

Expand Down Expand Up @@ -31,6 +30,6 @@ public function getInfo(): EditorInfoInterface;
*
* @throws IncompatibleEditorException
*/
public function create(array $config, $checkCompatible = false): EditorAdapterInterface;
public function create(array $config, bool $checkCompatible = false): EditorAdapterInterface;

}