Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation page for DID Methods #177

Merged
merged 57 commits into from
Mar 24, 2025
Merged

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Mar 13, 2025

Description of change

The documentation page can be previewed here: https://docs-git-docs-did-methods-impierce.vercel.app/unicore/introduction/features/did-methods

Links to any relevant issues

n/a

How the change has been tested

n/a

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@nanderstabel nanderstabel requested a review from Copilot March 13, 2025 16:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new documentation page describing DID Methods, including details on DID resolution, supported methods, and configuration options.

  • Introduces a comprehensive overview of DID Methods and their real-world application in decentralized identity verification.
  • Provides YAML configuration examples and detailed notes on Domain Linkage and ledger-based DID methods.

Base automatically changed from feat/did-iota to beta March 14, 2025 11:04
@nanderstabel nanderstabel changed the title docs: add documenation page for DID Methods docs: add documentation page for DID Methods Mar 19, 2025
@nanderstabel nanderstabel requested a review from Copilot March 20, 2025 07:31
@nanderstabel nanderstabel self-assigned this Mar 20, 2025
@nanderstabel nanderstabel added the Documentation Improvements or additions to documentation label Mar 20, 2025
@nanderstabel nanderstabel marked this pull request as ready for review March 20, 2025 07:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new documentation page outlining the DID Methods supported by UniCore and makes a minor code simplification in the Document view handling.

  • Adds a comprehensive markdown page in the docs directory describing DID Methods and their usage.
  • Refactors a pattern matching block in agent_identity to use a more concise variable binding.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/introduction/features/did-methods.md Added complete documentation for DID Methods.
agent_identity/src/document/views/mod.rs Simplified variable binding in the DocumentPublished match arm.

@nanderstabel nanderstabel merged commit 69f315a into beta Mar 24, 2025
7 checks passed
@nanderstabel nanderstabel deleted the docs/did-methods branch March 24, 2025 16:58
Copy link

🎉 This PR is included in version 1.0.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants