Skip to content

Conversation

@SoulaAndrikopoulos
Copy link
Contributor

@SoulaAndrikopoulos SoulaAndrikopoulos commented Oct 20, 2025

Description of change

  • Adds a link-style trigger (button) on the 'About UniMe' page that opens the T&C modal.
  • The dialog displays the full Terms of Use and includes two ways to close (an 'X' icon and a footer button).
  • With these changes users can now review the terms at any time, not just when they first sign up. It also increases transparency about our rules and legal information.

Links to any relevant issues

How the change has been tested

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader
Copy link
Collaborator

Refactoring hint: can we now use the extracted T&C's component in the onboarding as well?


<section class="flex flex-col items-center">
<button
data-component="Terms & Conditions"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think an ampersand is a valid character in the data-component - at least it's highlighted on my end. I'd remove it just to be sure not to introduce a bug by accident.

<!-- acts as <hr> -->
<div class="my-2 h-px w-full bg-brand"></div>

<!-- The modal content-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment shouldn't be necessary.

];
</script>

{#each termsContent as section}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

termsContent could be renamed to sections since it's a common pattern to use:

{#each <plural> as <singular>}

So like

{#each items as item}
or
{#each sections as section}

<div class="my-2 h-px w-full bg-brand"></div>

<!-- The modal content-->
<TermsAndConditions />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest renaming the TermsAndConditions component to TermsAndConditionsContent or TermsAndConditionsSections to make it more clear what it actually contains. Purely from looking at the component name TermsAndConditions, it's not directly clear whether it also contains the modal and/or a "close" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants