-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add Terms & Conditions dialog and button to 'About UniMe' page #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Refactoring hint: can we now use the extracted T&C's component in the onboarding as well? |
|
|
||
| <section class="flex flex-col items-center"> | ||
| <button | ||
| data-component="Terms & Conditions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think an ampersand is a valid character in the data-component - at least it's highlighted on my end. I'd remove it just to be sure not to introduce a bug by accident.
| <!-- acts as <hr> --> | ||
| <div class="my-2 h-px w-full bg-brand"></div> | ||
|
|
||
| <!-- The modal content--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment shouldn't be necessary.
| ]; | ||
| </script> | ||
|
|
||
| {#each termsContent as section} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
termsContent could be renamed to sections since it's a common pattern to use:
{#each <plural> as <singular>}
So like
{#each items as item}
or
{#each sections as section}
| <div class="my-2 h-px w-full bg-brand"></div> | ||
|
|
||
| <!-- The modal content--> | ||
| <TermsAndConditions /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest renaming the TermsAndConditions component to TermsAndConditionsContent or TermsAndConditionsSections to make it more clear what it actually contains. Purely from looking at the component name TermsAndConditions, it's not directly clear whether it also contains the modal and/or a "close" button.
Description of change
Links to any relevant issues
How the change has been tested
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.