Skip to content

Conversation

Oran-Dan
Copy link
Contributor

@Oran-Dan Oran-Dan commented Sep 7, 2024

Description of change

Before, the view popup on P2 & P3 would always show the candidate output based on the selected input field.
It didn't take into consideration whether the selected output field is a user input field or an informational field.
Now it will only show the candidate output if the output field selected takes user input.
If it's an informational field the popup displays the information.

Links to any relevant issues

How the change has been tested

Running the program and testing manually.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Oran-Dan Oran-Dan merged commit 8d42adf into main Sep 7, 2024
@Oran-Dan Oran-Dan deleted the feat/popup_display_field_info branch September 7, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant