fix(passport): facebook login no window opener #2650
Merged
+30
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattb8
changed the title
nattb8
changed the title
|
View your CI Pipeline Execution ↗ for commit 110b094.
☁️ Nx Cloud last updated this comment at |
nattb8
force-pushed
the
fix/facebook-login-no-window-opener
branch
from
3ff9769 to
ba3a8a8
Compare
nattb8
changed the title
ImmutableJeffrey
previously approved these changes
Jun 23, 2025
nattb8
force-pushed
the
fix/facebook-login-no-window-opener
branch
from
ba3a8a8 to
110b094
Compare
ImmutableJeffrey
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please ensure the PR title follows the below standards:
type(scope): message. For example:feat(passport): my new feature!after thetype(scope), for examplefeat(passport)!: my new breaking featureContext
ID-3722
ID-3736
Facebook login in Play is currently broken - users get stuck on the "Welcome, you're logged in" page and aren't redirected back to the app. This doesn't affect Google, Apple, or email login. The issue has been reproduced in the Passport sample app and is caused by a
No window.opener. Can't complete notification.error during the callback.The fix is in the latest
oidc-client-tsversion.Detail and impact of the change
Changed
Temporarily updated our TS SDK to depend on the
mainbranch ofoidc-client-tsto include the fix.Anything else worth calling out?
This will be published as an alpha release to unblock teams affected by the Facebook login issue.
Once
oidc-client-tspublishes an official release with the fix, we'll update our dependency accordingly and release a stable SDK version.