feat(checkout): Return price impact as part of the quote #2646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 1879502.
☁️ Nx Cloud last updated this comment at |
keithbro-imx
changed the title
jeetparikh
reviewed
Jun 4, 2025
| tradeType: TradeType, | ||
| ) { | ||
| const quoteAmount = quoteResult[amountIndex]; | ||
| if (typeof quoteAmount !== 'bigint') throw new Error('Expected BigNumber'); |
There was a problem hiding this comment.
could say expect bignumber but got ${typepof quoteAmont}` - helps with debugging
There was a problem hiding this comment.
true! this isn't new code fwiw, but i do agree.. i can update it in my next pr...
jeetparikh
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please ensure the PR title follows the below standards:
type(scope): message. For example:feat(passport): my new feature!after thetype(scope), for examplefeat(passport)!: my new breaking featureSummary
Return price impact of the trade as part of the quote.
Detail and impact of the change
Note that this is the price impact as calculated by comparing the midprice of the route and the execution price of the quote. It does not look at or consider the price impact on any of the pools individually.
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?