Skip to content

Fix typo in GOLANG_GUIDELINES.md #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in GOLANG_GUIDELINES.md #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions GOLANG_GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,8 +623,8 @@ type ReadWriter interface {
```

## Use interfaces to inject dependencies
* Injecting dependancies allows us to replace them with other implementations and mocks for testing
* Data / metadata is not a dependancy and should be passed in through integral types or value objects (e.g. do not pass config around)
* Injecting dependencies allows us to replace them with other implementations and mocks for testing
* Data / metadata is not a dependency and should be passed in through integral types or value objects (e.g. do not pass config around)

:white_check_mark: Good (client is injected, config types are not introduced at all):
```
Expand Down Expand Up @@ -697,4 +697,4 @@ func TestQualification_UsersAlreadyQualified_DoesNotDuplicateQualification(t *te
func TestQualificationUsersQualified(t *testing.T) {
...
}
```
```