Handle arm64 Scalable Vector Extension (SVE) types on clang 10 #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple things I'm not sure about.
…ince mysteriously disappeared.
ahomescu
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433.
This correctly handles arm64 Scalable Vector Extension (SVE) types on clang 10. SVE types were added in clang 10, but the API we had used to handle them was only added in clang 11, so they were being skipped in clang 10 and causing errors when transpiling any C file on
aarch64-unknown-linux-gnudue to the SVE types not being recognized. In clang <10, SVE types are not yet present, so this is not an issue there. Now theaarch64-unknown-linux-gnushould work in CI, which uses clang 10.