build: support cmake 4.0 #1214
Merged
build: support cmake 4.0 #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev>
kkysen
added a commit
that referenced
this pull request
May 1, 2025
you should probably also just merge - #1214 - #1212 pinning the `once_cell` version is a bit of a hack. It would not be needed if the rust version would update to `1.70.0`: https://doc.rust-lang.org/beta/std/cell/struct.OnceCell.html The github CI action still fails to translate curl even with these changes, and it doesn't really give any error message. So I'm not sure what to do with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump
cmake_minimum_requiredto support cmake 4.0 build