analyze: run equiv pass before pointee #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahomescu
approved these changes
Dec 3, 2024
| fn pointee_type(&self, ptr: PointerId) -> Option<LTy<'tcx>> { | ||
| self.pointee_types | ||
| .as_ref() | ||
| .and_then(|pointee_types| pointee_types[ptr].get_sole_lty()) |
There was a problem hiding this comment.
Will this panic if ptr is out of bounds?
There was a problem hiding this comment.
It will panic if ptr is PointerId::NONE (the same is true of the code this is replacing). I added an assert just to make it clear that this should only be called on actual pointers: 7f1d501
spernsteiner
force-pushed
the
analyze-equiv-before-pointee-base
branch
from
74a6d31 to
955f20b
Compare
spernsteiner
force-pushed
the
analyze-equiv-before-pointee
branch
from
d4efb1a to
7f1d501
Compare
This gives more useful panic locations when a `FuncInfo` field is accessed while unset.
spernsteiner
force-pushed
the
analyze-equiv-before-pointee-base
branch
from
955f20b to
a0850b1
Compare
spernsteiner
force-pushed
the
analyze-equiv-before-pointee
branch
from
7f1d501 to
e1c17c4
Compare
spernsteiner
changed the base branch from
analyze-equiv-before-pointee-base
to
master
spernsteiner
force-pushed
the
analyze-equiv-before-pointee
branch
from
e1c17c4 to
7013b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch changes the order of analysis passes to run the equivalence class analysis and
PointerIdrenumbering before running the pointee type analysis. In particular, this improves the pointee results in cases involvingfreshreferences, such as this new test case:Most of the changes here are refactorings to move specific analysis passes from
run()into helper functions, which makes them easier to reorder.