Translate builtin_assume and unaligned SIMD intrinsics
#1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unaligned vector types such as `__m128_u` or `__256_u` not not have any equivalents in Rust so we translate them to their aligned equivalents. This is unsound so we emit warning that the program may be mistranspiled.
thedataking
force-pushed
the
perl/builtin_assume
branch
from
8cc6c91
to
fb3add3
Compare
kkysen
reviewed
Sep 21, 2024
Comment on lines
+617
to
+618
| // TODO: provide proper implementation, this is just to get stuff building | ||
| "__builtin_assume" => Ok(self.convert_expr(ctx.used(), args[0])?), |
There was a problem hiding this comment.
When you do implement this, note that Rust (as of 1.81.0) now has core::hint::assert_unchecked, which should be the equivalent of __builtin_assume.
kkysen
reviewed
Sep 23, 2024
There was a problem hiding this comment.
There does seem to be some unaligned stuff in stdarch.
For example, _mm_storeu_si128.
Also, https://doc.rust-lang.org/std/arch/index.html?search=loadu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unaligned vector types such as
__m128_uor__256_unot not have any equivalents in Rust so we translate them to their aligned equivalents. This is unsound so we emit warning that the program may be mistranspiled. These fixes are required to transpile thezstdcompressor on modern x86 hosts.