Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scripts/pdg.sh more flexible for more use cases #1113

Open
wants to merge 1 commit into
base: ahomescu/non_null
Choose a base branch
from
Open

Make scripts/pdg.sh more flexible for more use cases #1113

wants to merge 1 commit into from
+130 −77

Conversation

ahomescu
Copy link
Contributor

No description provided.

@ahomescu ahomescu changed the base branch from master to ahomescu/non_null August 28, 2024 01:37
@ahomescu ahomescu force-pushed the ahomescu/update_pdg_script branch 2 times, most recently from 3156827 to 27dfd51 Compare August 28, 2024 02:02
@kkysen kkysen self-assigned this Aug 28, 2024
kkysen
kkysen reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this trying to accomplish exactly?

The intention was to make the script obsolete over time, as the functionality is also available pdg/src/main.rs's mod tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkysen kkysen kkysen left review comments

@spernsteiner spernsteiner Awaiting requested review from spernsteiner

Assignees

@kkysen kkysen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahomescu @kkysen