Skip to content

Integration test suite scripts don't always report errors correctly #1519

@randomPoison

Description

@randomPoison

I ran into an issue when trying to run the curl integration test because I didn't have jq installed, and noticed that the output didn't actually report the failing command until I passed --verbose.

`./test.py curl` output failing to report cause of failure
random@DESKTOP-RUM8J14:~/dev/c2rust/tests/integration$ ./test.py curl
info: checking requirements(tests/conf.yml)
info: checking requirements(tests/curl/conf.yml)
curl: autogen(tests/curl/autogen.sh).............................. OK
curl: configure(tests/curl/configure.sh).......................... OK
curl: make(tests/curl/make.sh).................................... FAIL
  CC       libcurl_la-strerror.lo
  CC       libcurl_la-system_win32.lo
  CC       libcurl_la-telnet.lo
  CC       libcurl_la-tftp.lo
  CC       libcurl_la-transfer.lo
  CC       libcurl_la-uint-bset.lo
  CC       libcurl_la-uint-hash.lo
  CC       libcurl_la-uint-table.lo
  CC       libcurl_la-uint-spbset.lo
  CC       libcurl_la-url.lo
  CC       libcurl_la-urlapi.lo
  CC       libcurl_la-version.lo
  CC       libcurl_la-ws.lo
  CC       libcurlu_la-altsvc.lo
  CC       libcurlu_la-amigaos.lo
  CC       libcurlu_la-asyn-ares.lo
  CC       libcurlu_la-asyn-base.lo
  CC       libcurlu_la-asyn-thrdd.lo
  CC       libcurlu_la-bufq.lo
  CC       libcurlu_la-bufref.lo
  CC       libcurlu_la-cf-h1-proxy.lo
--
  CC       libcurlu_la-strerror.lo
  CC       libcurlu_la-system_win32.lo
  CC       libcurlu_la-telnet.lo
  CC       libcurlu_la-tftp.lo
  CC       libcurlu_la-transfer.lo
  CC       libcurlu_la-uint-bset.lo
  CC       libcurlu_la-uint-hash.lo
  CC       libcurlu_la-uint-spbset.lo
  CC       libcurlu_la-uint-table.lo
  CC       libcurlu_la-url.lo
  CC       libcurlu_la-urlapi.lo
  CC       libcurlu_la-version.lo
  CC       libcurlu_la-ws.lo
  CC       vauth/libcurlu_la-cleartext.lo
  CC       vauth/libcurlu_la-cram.lo
  CC       vauth/libcurlu_la-digest.lo
  CC       vauth/libcurlu_la-digest_sspi.lo
  CC       vauth/libcurlu_la-gsasl.lo
  CC       vauth/libcurlu_la-krb5_gssapi.lo
  CC       vauth/libcurlu_la-krb5_sspi.lo
  CC       vauth/libcurlu_la-ntlm.lo
  CC       ../lib/curlx/libcurltool_la-nonblock.lo
  CC       ../lib/curlx/libcurltool_la-strparse.lo
  CC       ../lib/curlx/libcurltool_la-timediff.lo
  CC       ../lib/curlx/libcurltool_la-timeval.lo
  CC       ../lib/curlx/libcurltool_la-version_win32.lo
  CC       ../lib/curlx/libcurltool_la-warnless.lo
  CC       curl-tool_hugehelp.o
  CC       curl-tool_ca_embed.o
  CCLD     curlinfo
  CCLD     curl
  CCLD     libcurltool.la
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/src'
Making all in scripts
make[1]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/scripts'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/scripts'
make[1]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo'
make[1]: Nothing to be done for 'all-am'.
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo'
make: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo'
curl failed on stage make
curl took 0:00:47.182393
projects failed: curl

If I pass --verbose then in the output I see:

/home/random/dev/c2rust/tests/integration/tests/curl/make.sh: line 17: jq: command not found

The error also doesn't show up in make.sh.log:

`make.sh.log` also doesn't capture the cause of the failure
make: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo'
Making all in lib
make[1]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/lib'
make  all-am
make[2]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/lib'
  CC       libcurl_la-altsvc.lo
  CC       libcurl_la-amigaos.lo
  CC       libcurl_la-asyn-ares.lo
  CC       libcurl_la-asyn-base.lo
  CC       libcurl_la-asyn-thrdd.lo
  CC       libcurl_la-bufq.lo
  CC       libcurl_la-bufref.lo
  CC       libcurl_la-cf-h1-proxy.lo
  CC       libcurl_la-cf-h2-proxy.lo
  CC       libcurl_la-cf-haproxy.lo
  CC       libcurl_la-cf-https-connect.lo
  CC       libcurl_la-cf-socket.lo
  CC       libcurl_la-cfilters.lo
  CC       libcurl_la-conncache.lo
  CC       libcurl_la-connect.lo
  CC       libcurl_la-content_encoding.lo
  CC       libcurl_la-cookie.lo
  CC       libcurl_la-cshutdn.lo
  CC       libcurl_la-curl_addrinfo.lo
  CC       libcurl_la-curl_des.lo
  CC       libcurl_la-curl_endian.lo
  CC       libcurl_la-curl_fnmatch.lo
  CC       libcurl_la-curl_get_line.lo
  CC       libcurl_la-curl_gethostname.lo
  CC       libcurl_la-curl_gssapi.lo
  CC       libcurl_la-curl_memrchr.lo
  CC       libcurl_la-curl_ntlm_core.lo
  CC       libcurl_la-curl_range.lo
  CC       libcurl_la-curl_rtmp.lo
  CC       libcurl_la-curl_sasl.lo
  CC       libcurl_la-curl_sha512_256.lo
  CC       libcurl_la-curl_sspi.lo
  CC       libcurl_la-curl_threads.lo
  CC       libcurl_la-curl_trc.lo
  CC       libcurl_la-cw-out.lo
  CC       libcurl_la-cw-pause.lo
  CC       libcurl_la-dict.lo
  CC       libcurl_la-doh.lo
  CC       libcurl_la-dynhds.lo
  CC       libcurl_la-easy.lo
  CC       libcurl_la-easygetopt.lo
  CC       libcurl_la-easyoptions.lo
  CC       libcurl_la-escape.lo
  CC       libcurl_la-fake_addrinfo.lo
  CC       libcurl_la-file.lo
  CC       libcurl_la-fileinfo.lo
  CC       libcurl_la-fopen.lo
  CC       libcurl_la-ftp.lo
  CC       libcurl_la-formdata.lo
  CC       libcurl_la-ftplistparser.lo
  CC       libcurl_la-getenv.lo
  CC       libcurl_la-getinfo.lo
  CC       libcurl_la-gopher.lo
  CC       libcurl_la-hash.lo
  CC       libcurl_la-headers.lo
  CC       libcurl_la-hmac.lo
  CC       libcurl_la-hostip.lo
  CC       libcurl_la-hostip4.lo
  CC       libcurl_la-hostip6.lo
  CC       libcurl_la-hsts.lo
  CC       libcurl_la-http.lo
  CC       libcurl_la-http1.lo
  CC       libcurl_la-http2.lo
  CC       libcurl_la-http_aws_sigv4.lo
  CC       libcurl_la-http_chunks.lo
  CC       libcurl_la-http_digest.lo
  CC       libcurl_la-http_negotiate.lo
  CC       libcurl_la-http_ntlm.lo
  CC       libcurl_la-http_proxy.lo
  CC       libcurl_la-httpsrr.lo
  CC       libcurl_la-idn.lo
  CC       libcurl_la-if2ip.lo
  CC       libcurl_la-imap.lo
  CC       libcurl_la-inet_ntop.lo
  CC       libcurl_la-krb5.lo
  CC       libcurl_la-ldap.lo
  CC       libcurl_la-llist.lo
  CC       libcurl_la-macos.lo
  CC       libcurl_la-md4.lo
  CC       libcurl_la-md5.lo
  CC       libcurl_la-memdebug.lo
  CC       libcurl_la-mime.lo
  CC       libcurl_la-mprintf.lo
  CC       libcurl_la-mqtt.lo
  CC       libcurl_la-multi.lo
  CC       libcurl_la-multi_ev.lo
  CC       libcurl_la-netrc.lo
  CC       libcurl_la-noproxy.lo
  CC       libcurl_la-openldap.lo
  CC       libcurl_la-parsedate.lo
  CC       libcurl_la-pingpong.lo
  CC       libcurl_la-pop3.lo
  CC       libcurl_la-progress.lo
  CC       libcurl_la-psl.lo
  CC       libcurl_la-rand.lo
  CC       libcurl_la-rename.lo
  CC       libcurl_la-request.lo
  CC       libcurl_la-rtsp.lo
  CC       libcurl_la-select.lo
  CC       libcurl_la-sendf.lo
  CC       libcurl_la-setopt.lo
  CC       libcurl_la-sha256.lo
  CC       libcurl_la-share.lo
  CC       libcurl_la-slist.lo
  CC       libcurl_la-smb.lo
  CC       libcurl_la-smtp.lo
  CC       libcurl_la-socketpair.lo
  CC       libcurl_la-socks.lo
  CC       libcurl_la-socks_gssapi.lo
  CC       libcurl_la-socks_sspi.lo
  CC       libcurl_la-speedcheck.lo
  CC       libcurl_la-splay.lo
  CC       libcurl_la-strcase.lo
  CC       libcurl_la-strdup.lo
  CC       libcurl_la-strequal.lo
  CC       libcurl_la-strerror.lo
  CC       libcurl_la-system_win32.lo
  CC       libcurl_la-telnet.lo
  CC       libcurl_la-tftp.lo
  CC       libcurl_la-transfer.lo
  CC       libcurl_la-uint-bset.lo
  CC       libcurl_la-uint-hash.lo
  CC       libcurl_la-uint-table.lo
  CC       libcurl_la-uint-spbset.lo
  CC       libcurl_la-url.lo
  CC       libcurl_la-urlapi.lo
  CC       libcurl_la-version.lo
  CC       libcurl_la-ws.lo
  CC       libcurlu_la-altsvc.lo
  CC       libcurlu_la-amigaos.lo
  CC       libcurlu_la-asyn-ares.lo
  CC       libcurlu_la-asyn-base.lo
  CC       libcurlu_la-asyn-thrdd.lo
  CC       libcurlu_la-bufq.lo
  CC       libcurlu_la-bufref.lo
  CC       libcurlu_la-cf-h1-proxy.lo
  CC       libcurlu_la-cf-h2-proxy.lo
  CC       libcurlu_la-cf-haproxy.lo
  CC       libcurlu_la-cf-https-connect.lo
  CC       libcurlu_la-cf-socket.lo
  CC       libcurlu_la-cfilters.lo
  CC       libcurlu_la-conncache.lo
  CC       libcurlu_la-connect.lo
  CC       libcurlu_la-content_encoding.lo
  CC       libcurlu_la-cookie.lo
  CC       libcurlu_la-cshutdn.lo
  CC       libcurlu_la-curl_addrinfo.lo
  CC       libcurlu_la-curl_des.lo
  CC       libcurlu_la-curl_endian.lo
  CC       libcurlu_la-curl_fnmatch.lo
  CC       libcurlu_la-curl_get_line.lo
  CC       libcurlu_la-curl_gethostname.lo
  CC       libcurlu_la-curl_gssapi.lo
  CC       libcurlu_la-curl_memrchr.lo
  CC       libcurlu_la-curl_ntlm_core.lo
  CC       libcurlu_la-curl_range.lo
  CC       libcurlu_la-curl_rtmp.lo
  CC       libcurlu_la-curl_sasl.lo
  CC       libcurlu_la-curl_sha512_256.lo
  CC       libcurlu_la-curl_sspi.lo
  CC       libcurlu_la-curl_threads.lo
  CC       libcurlu_la-curl_trc.lo
  CC       libcurlu_la-cw-out.lo
  CC       libcurlu_la-cw-pause.lo
  CC       libcurlu_la-dict.lo
  CC       libcurlu_la-doh.lo
  CC       libcurlu_la-dynhds.lo
  CC       libcurlu_la-easy.lo
  CC       libcurlu_la-easygetopt.lo
  CC       libcurlu_la-easyoptions.lo
  CC       libcurlu_la-escape.lo
  CC       libcurlu_la-fake_addrinfo.lo
  CC       libcurlu_la-file.lo
  CC       libcurlu_la-fileinfo.lo
  CC       libcurlu_la-fopen.lo
  CC       libcurlu_la-formdata.lo
  CC       libcurlu_la-ftp.lo
  CC       libcurlu_la-ftplistparser.lo
  CC       libcurlu_la-getenv.lo
  CC       libcurlu_la-getinfo.lo
  CC       libcurlu_la-gopher.lo
  CC       libcurlu_la-hash.lo
  CC       libcurlu_la-headers.lo
  CC       libcurlu_la-hmac.lo
  CC       libcurlu_la-hostip.lo
  CC       libcurlu_la-hostip4.lo
  CC       libcurlu_la-hostip6.lo
  CC       libcurlu_la-hsts.lo
  CC       libcurlu_la-http.lo
  CC       libcurlu_la-http1.lo
  CC       libcurlu_la-http2.lo
  CC       libcurlu_la-http_aws_sigv4.lo
  CC       libcurlu_la-http_chunks.lo
  CC       libcurlu_la-http_digest.lo
  CC       libcurlu_la-http_negotiate.lo
  CC       libcurlu_la-http_ntlm.lo
  CC       libcurlu_la-http_proxy.lo
  CC       libcurlu_la-httpsrr.lo
  CC       libcurlu_la-idn.lo
  CC       libcurlu_la-if2ip.lo
  CC       libcurlu_la-imap.lo
  CC       libcurlu_la-inet_ntop.lo
  CC       libcurlu_la-krb5.lo
  CC       libcurlu_la-ldap.lo
  CC       libcurlu_la-llist.lo
  CC       libcurlu_la-macos.lo
  CC       libcurlu_la-md4.lo
  CC       libcurlu_la-md5.lo
  CC       libcurlu_la-memdebug.lo
  CC       libcurlu_la-mime.lo
  CC       libcurlu_la-mprintf.lo
  CC       libcurlu_la-mqtt.lo
  CC       libcurlu_la-multi.lo
  CC       libcurlu_la-multi_ev.lo
  CC       libcurlu_la-netrc.lo
  CC       libcurlu_la-noproxy.lo
  CC       libcurlu_la-openldap.lo
  CC       libcurlu_la-parsedate.lo
  CC       libcurlu_la-pingpong.lo
  CC       libcurlu_la-pop3.lo
  CC       libcurlu_la-progress.lo
  CC       libcurlu_la-psl.lo
  CC       libcurlu_la-rand.lo
  CC       libcurlu_la-rename.lo
  CC       libcurlu_la-request.lo
  CC       libcurlu_la-rtsp.lo
  CC       libcurlu_la-select.lo
  CC       libcurlu_la-sendf.lo
  CC       libcurlu_la-setopt.lo
  CC       libcurlu_la-sha256.lo
  CC       libcurlu_la-share.lo
  CC       libcurlu_la-slist.lo
  CC       libcurlu_la-smb.lo
  CC       libcurlu_la-smtp.lo
  CC       libcurlu_la-socketpair.lo
  CC       libcurlu_la-socks.lo
  CC       libcurlu_la-socks_gssapi.lo
  CC       libcurlu_la-socks_sspi.lo
  CC       libcurlu_la-speedcheck.lo
  CC       libcurlu_la-splay.lo
  CC       libcurlu_la-strcase.lo
  CC       libcurlu_la-strdup.lo
  CC       libcurlu_la-strequal.lo
  CC       libcurlu_la-strerror.lo
  CC       libcurlu_la-system_win32.lo
  CC       libcurlu_la-telnet.lo
  CC       libcurlu_la-tftp.lo
  CC       libcurlu_la-transfer.lo
  CC       libcurlu_la-uint-bset.lo
  CC       libcurlu_la-uint-hash.lo
  CC       libcurlu_la-uint-spbset.lo
  CC       libcurlu_la-uint-table.lo
  CC       libcurlu_la-url.lo
  CC       libcurlu_la-urlapi.lo
  CC       libcurlu_la-version.lo
  CC       libcurlu_la-ws.lo
  CC       vauth/libcurlu_la-cleartext.lo
  CC       vauth/libcurlu_la-cram.lo
  CC       vauth/libcurlu_la-digest.lo
  CC       vauth/libcurlu_la-digest_sspi.lo
  CC       vauth/libcurlu_la-gsasl.lo
  CC       vauth/libcurlu_la-krb5_gssapi.lo
  CC       vauth/libcurlu_la-krb5_sspi.lo
  CC       vauth/libcurlu_la-ntlm.lo
  CC       vauth/libcurlu_la-ntlm_sspi.lo
  CC       vauth/libcurlu_la-oauth2.lo
  CC       vauth/libcurlu_la-spnego_gssapi.lo
  CC       vauth/libcurlu_la-spnego_sspi.lo
  CC       vauth/libcurlu_la-vauth.lo
  CC       vtls/libcurlu_la-bearssl.lo
  CC       vtls/libcurlu_la-cipher_suite.lo
  CC       vtls/libcurlu_la-gtls.lo
  CC       vtls/libcurlu_la-hostcheck.lo
  CC       vtls/libcurlu_la-keylog.lo
  CC       vtls/libcurlu_la-mbedtls.lo
  CC       vtls/libcurlu_la-mbedtls_threadlock.lo
  CC       vtls/libcurlu_la-openssl.lo
  CC       vtls/libcurlu_la-rustls.lo
  CC       vtls/libcurlu_la-schannel.lo
  CC       vtls/libcurlu_la-schannel_verify.lo
  CC       vtls/libcurlu_la-sectransp.lo
  CC       vtls/libcurlu_la-vtls.lo
  CC       vtls/libcurlu_la-vtls_scache.lo
  CC       vtls/libcurlu_la-vtls_spack.lo
  CC       vtls/libcurlu_la-wolfssl.lo
  CC       vtls/libcurlu_la-x509asn1.lo
  CC       vquic/libcurlu_la-curl_msh3.lo
  CC       vquic/libcurlu_la-curl_ngtcp2.lo
  CC       vquic/libcurlu_la-curl_osslq.lo
  CC       vquic/libcurlu_la-curl_quiche.lo
  CC       vquic/libcurlu_la-vquic.lo
  CC       vquic/libcurlu_la-vquic-tls.lo
  CC       vssh/libcurlu_la-libssh.lo
  CC       vssh/libcurlu_la-libssh2.lo
  CC       vssh/libcurlu_la-curl_path.lo
  CC       vssh/libcurlu_la-wolfssh.lo
  CC       curlx/libcurlu_la-base64.lo
  CC       curlx/libcurlu_la-dynbuf.lo
  CC       curlx/libcurlu_la-inet_pton.lo
  CC       curlx/libcurlu_la-multibyte.lo
  CC       curlx/libcurlu_la-nonblock.lo
  CC       curlx/libcurlu_la-strparse.lo
  CC       curlx/libcurlu_la-timediff.lo
  CC       curlx/libcurlu_la-timeval.lo
  CC       curlx/libcurlu_la-version_win32.lo
  CC       curlx/libcurlu_la-warnless.lo
  CC       curlx/libcurlu_la-winapi.lo
  CC       vauth/libcurl_la-cleartext.lo
  CC       vauth/libcurl_la-cram.lo
  CC       vauth/libcurl_la-digest.lo
  CC       vauth/libcurl_la-digest_sspi.lo
  CC       vauth/libcurl_la-gsasl.lo
  CC       vauth/libcurl_la-krb5_gssapi.lo
  CC       vauth/libcurl_la-krb5_sspi.lo
  CC       vauth/libcurl_la-ntlm.lo
  CC       vauth/libcurl_la-ntlm_sspi.lo
  CC       vauth/libcurl_la-oauth2.lo
  CC       vauth/libcurl_la-spnego_gssapi.lo
  CC       vauth/libcurl_la-spnego_sspi.lo
  CC       vauth/libcurl_la-vauth.lo
  CC       vtls/libcurl_la-bearssl.lo
  CC       vtls/libcurl_la-cipher_suite.lo
  CC       vtls/libcurl_la-gtls.lo
  CC       vtls/libcurl_la-hostcheck.lo
  CC       vtls/libcurl_la-keylog.lo
  CC       vtls/libcurl_la-mbedtls.lo
  CC       vtls/libcurl_la-openssl.lo
  CC       vtls/libcurl_la-mbedtls_threadlock.lo
  CC       vtls/libcurl_la-rustls.lo
  CC       vtls/libcurl_la-schannel.lo
  CC       vtls/libcurl_la-schannel_verify.lo
  CC       vtls/libcurl_la-sectransp.lo
  CC       vtls/libcurl_la-vtls.lo
  CC       vtls/libcurl_la-vtls_scache.lo
  CC       vtls/libcurl_la-vtls_spack.lo
  CC       vtls/libcurl_la-wolfssl.lo
  CC       vtls/libcurl_la-x509asn1.lo
  CC       vquic/libcurl_la-curl_msh3.lo
  CC       vquic/libcurl_la-curl_ngtcp2.lo
  CC       vquic/libcurl_la-curl_osslq.lo
  CC       vquic/libcurl_la-curl_quiche.lo
  CC       vquic/libcurl_la-vquic.lo
  CC       vquic/libcurl_la-vquic-tls.lo
  CC       vssh/libcurl_la-libssh.lo
  CC       vssh/libcurl_la-libssh2.lo
  CC       vssh/libcurl_la-curl_path.lo
  CC       vssh/libcurl_la-wolfssh.lo
  CC       curlx/libcurl_la-base64.lo
  CC       curlx/libcurl_la-dynbuf.lo
  CC       curlx/libcurl_la-inet_pton.lo
  CC       curlx/libcurl_la-multibyte.lo
  CC       curlx/libcurl_la-nonblock.lo
  CC       curlx/libcurl_la-strparse.lo
  CC       curlx/libcurl_la-timediff.lo
  CC       curlx/libcurl_la-timeval.lo
  CC       curlx/libcurl_la-version_win32.lo
  CC       curlx/libcurl_la-warnless.lo
  CC       curlx/libcurl_la-winapi.lo
  CCLD     libcurlu.la
  CCLD     libcurl.la
make[2]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/lib'
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/lib'
Making all in docs
make[1]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs'
Making all in .
make[2]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs'
make[2]: Nothing to be done for 'all-am'.
make[2]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs'
Making all in cmdline-opts
make[2]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/cmdline-opts'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/cmdline-opts'
Making all in libcurl
make[2]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/libcurl'
Making all in opts
make[3]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/libcurl/opts'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/libcurl/opts'
make[3]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/libcurl'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/libcurl'
make[2]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs/libcurl'
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/docs'
Making all in src
make[1]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/src'
  CC       curl-config2setopts.o
  CC       curl-slist_wc.o
  CC       curl-terminal.o
  CC       curl-tool_bname.o
  CC       curl-tool_cb_dbg.o
  CC       curl-tool_cb_hdr.o
  CC       curl-tool_cb_prg.o
  CC       curl-tool_cb_rea.o
  CC       curl-tool_cb_see.o
  CC       curl-tool_cb_soc.o
  CC       curl-tool_cb_wrt.o
  CC       curl-tool_cfgable.o
  CC       curl-tool_dirhie.o
  CC       curl-tool_doswin.o
  CC       curl-tool_easysrc.o
  CC       curl-tool_filetime.o
  CC       curl-tool_findfile.o
  CC       curl-tool_formparse.o
  CC       curl-tool_getparam.o
  CC       curl-tool_getpass.o
  CC       curl-tool_help.o
  CC       curl-tool_helpers.o
  CC       curl-tool_ipfs.o
  CC       curl-tool_libinfo.o
  CC       curl-tool_listhelp.o
  CC       curl-tool_main.o
  CC       curl-tool_msgs.o
  CC       curl-tool_operate.o
  CC       curl-tool_operhlp.o
  CC       curl-tool_paramhlp.o
  CC       curl-tool_parsecfg.o
  CC       curl-tool_progress.o
  CC       curl-tool_setopt.o
  CC       curl-tool_sleep.o
  CC       curl-tool_ssls.o
  CC       curl-tool_stderr.o
  CC       curl-tool_strdup.o
  CC       curl-tool_urlglob.o
  CC       curl-tool_util.o
  CC       curl-tool_vms.o
  CC       curl-tool_writeout.o
  CC       curl-tool_writeout_json.o
  CC       curl-tool_xattr.o
  CC       curl-var.o
  CC       ../lib/curlx/curl-base64.o
  CC       ../lib/curlx/curl-multibyte.o
  CC       ../lib/curlx/curl-dynbuf.o
  CC       ../lib/curlx/curl-nonblock.o
  CC       ../lib/curlx/curl-strparse.o
  CC       ../lib/curlx/curl-timediff.o
  CC       ../lib/curlx/curl-timeval.o
  CC       ../lib/curlx/curl-version_win32.o
  CC       ../lib/curlx/curl-warnless.o
echo '/* !checksrc! disable COPYRIGHT all */' > tool_hugehelp.c;   \
echo '#include "tool_hugehelp.h"' >> tool_hugehelp.c
echo '/* !checksrc! disable COPYRIGHT all */' > tool_ca_embed.c
echo 'extern const void *curl_ca_embed; const void *curl_ca_embed;' >> tool_ca_embed.c
  CC       curlinfo.o
  CC       libcurltool_la-config2setopts.lo
  CC       libcurltool_la-slist_wc.lo
  CC       libcurltool_la-terminal.lo
  CC       libcurltool_la-tool_bname.lo
  CC       libcurltool_la-tool_cb_dbg.lo
  CC       libcurltool_la-tool_cb_hdr.lo
  CC       libcurltool_la-tool_cb_prg.lo
  CC       libcurltool_la-tool_cb_rea.lo
  CC       libcurltool_la-tool_cb_see.lo
  CC       libcurltool_la-tool_cb_soc.lo
  CC       libcurltool_la-tool_cb_wrt.lo
  CC       libcurltool_la-tool_cfgable.lo
  CC       libcurltool_la-tool_dirhie.lo
  CC       libcurltool_la-tool_doswin.lo
  CC       libcurltool_la-tool_easysrc.lo
  CC       libcurltool_la-tool_filetime.lo
  CC       libcurltool_la-tool_findfile.lo
  CC       libcurltool_la-tool_formparse.lo
  CC       libcurltool_la-tool_getparam.lo
  CC       libcurltool_la-tool_getpass.lo
  CC       libcurltool_la-tool_help.lo
  CC       libcurltool_la-tool_helpers.lo
  CC       libcurltool_la-tool_ipfs.lo
  CC       libcurltool_la-tool_libinfo.lo
  CC       libcurltool_la-tool_listhelp.lo
  CC       libcurltool_la-tool_main.lo
  CC       libcurltool_la-tool_msgs.lo
  CC       libcurltool_la-tool_operate.lo
  CC       libcurltool_la-tool_operhlp.lo
  CC       libcurltool_la-tool_paramhlp.lo
  CC       libcurltool_la-tool_parsecfg.lo
  CC       libcurltool_la-tool_progress.lo
  CC       libcurltool_la-tool_setopt.lo
  CC       libcurltool_la-tool_sleep.lo
  CC       libcurltool_la-tool_ssls.lo
  CC       libcurltool_la-tool_stderr.lo
  CC       libcurltool_la-tool_strdup.lo
  CC       libcurltool_la-tool_urlglob.lo
  CC       libcurltool_la-tool_util.lo
  CC       libcurltool_la-tool_vms.lo
  CC       libcurltool_la-tool_writeout.lo
  CC       libcurltool_la-tool_writeout_json.lo
  CC       libcurltool_la-tool_xattr.lo
  CC       libcurltool_la-var.lo
  CC       ../lib/curlx/libcurltool_la-base64.lo
  CC       ../lib/curlx/libcurltool_la-multibyte.lo
  CC       ../lib/curlx/libcurltool_la-dynbuf.lo
  CC       ../lib/curlx/libcurltool_la-nonblock.lo
  CC       ../lib/curlx/libcurltool_la-strparse.lo
  CC       ../lib/curlx/libcurltool_la-timediff.lo
  CC       ../lib/curlx/libcurltool_la-timeval.lo
  CC       ../lib/curlx/libcurltool_la-version_win32.lo
  CC       ../lib/curlx/libcurltool_la-warnless.lo
  CC       curl-tool_hugehelp.o
  CC       curl-tool_ca_embed.o
  CCLD     curlinfo
  CCLD     curl
  CCLD     libcurltool.la
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/src'
Making all in scripts
make[1]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/scripts'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo/scripts'
make[1]: Entering directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo'
make[1]: Nothing to be done for 'all-am'.
make[1]: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo'
make: Leaving directory '/home/random/dev/c2rust/tests/integration/tests/curl/repo'

It would be easier to address issues like this if the actual error message showed up in the command output, or at least in make.sh.log. @fw-immunant suggested the fix would be:

diff --git a/tests/integration/tests/curl/make.sh b/tests/integration/tests/curl/make.sh
index a44d1e515..7efe8bfde 100755
--- a/tests/integration/tests/curl/make.sh
+++ b/tests/integration/tests/curl/make.sh
@@ -6,17 +6,21 @@ make -C "$SCRIPT_DIR/repo" clean && rm -f compile_commands.json
 intercept-build make -C "$SCRIPT_DIR/repo" -j`nproc` 2>&1 \
     | tee `basename "$0"`.log
 
-# remove compile_commands entries where `arguments` contains `UNITTEST` 
-# this is necessary because tool_main.c only defines main if `UNITTESTS` is not defined
-# I did not find a good way to disable unittests via the configure script which would have been cleaner
-tmp=$(mktemp)
-jq 'map(select((.arguments // []) | any(.[]; contains("DUNITTESTS")) | not))' $SCRIPT_DIR/compile_commands.json > "$tmp"
-cp "$tmp" $SCRIPT_DIR/compile_commands.json
+(
+    # remove compile_commands entries where `arguments` contains `UNITTEST` 
+    # this is necessary because tool_main.c only defines main if `UNITTESTS` is not defined
+    # I did not find a good way to disable unittests via the configure script which would have been cleaner
+    tmp=$(mktemp)
+    jq 'map(select((.arguments // []) | any(.[]; contains("DUNITTESTS")) | not))' $SCRIPT_DIR/compile_commands.json > "$tmp"
+    cp "$tmp" $SCRIPT_DIR/compile_commands.json
+) 2>&1 | tee `basename "$0"`.log
 
-# work around https://github.com/immunant/c2rust/issues/1319
-#
-# remove compile_commands where `file` starts with `../lib/curlx` because clang-15 may pick the wrong compile_commands.json
-# entry which causes the transpiler to fail because it doesn't get the right include paths. clang-18 does not seem to have
-# this problem which indicates the problem is not in the transpiler.
-jq 'map(select(.file | startswith("../lib/curlx") | not))' $SCRIPT_DIR/compile_commands.json > "$tmp"
-mv "$tmp" $SCRIPT_DIR/compile_commands.json
\ No newline at end of file
+(
+    # work around https://github.com/immunant/c2rust/issues/1319
+    #
+    # remove compile_commands where `file` starts with `../lib/curlx` because clang-15 may pick the wrong compile_commands.json
+    # entry which causes the transpiler to fail because it doesn't get the right include paths. clang-18 does not seem to have
+    # this problem which indicates the problem is not in the transpiler.
+    jq 'map(select(.file | startswith("../lib/curlx") | not))' $SCRIPT_DIR/compile_commands.json > "$tmp"
+    mv "$tmp" $SCRIPT_DIR/compile_commands.json
+) 2>&1 | tee `basename "$0"`.log

It may be worth seeing if we can handle this better generally so that we don't risk forgetting to do this in future scripts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsProblems with the unit or integration tests

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions