Minor rewriter fixes and cleanups #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we mistakenly used typedef_decl here instead of type_alias_decl
kkysen
reviewed
Mar 14, 2025
| @@ -513,16 +513,14 @@ class FnPtrCall : public RefactoringCallback { | |||
|
|
|||
| std::string new_expr = | |||
| "IA2_CALL("s + old_callee.str() + ", " + mangled_ty; | |||
|
|
|||
There was a problem hiding this comment.
It'd be nice to merge in #518 first so we don't have these same formatting changes in a bunch of different PRs (I've seen this one, too, in a bunch of mine).
kkysen
reviewed
Mar 14, 2025
| @@ -597,7 +595,6 @@ class FnPtrExpr : public RefactoringCallback { | |||
| auto *fn_ptr_expr = result.Nodes.getNodeAs<clang::DeclRefExpr>("fnPtrExpr"); | |||
| assert(fn_ptr_expr != nullptr); | |||
|
|
|||
| auto annotation = fn_ptr_expr->getDecl()->getAttr<clang::AnnotateAttr>(); | |||
There was a problem hiding this comment.
This is dead code, right? I've seen a warning for it for a while
kkysen
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off of library-only mode, sending PR to keep that branch closer to
main. The only real semantic change here is a fix for a bug in type alias handling.