Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError while detecting version #34

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dpedu
Copy link

@dpedu dpedu commented May 11, 2019

This is #33, rebased per @immunIT's request.

@immunIT
Copy link
Collaborator

immunIT commented Jun 3, 2019

Hi @dpedu,

I reviewed your pull request and when tested, it triggered the following error (cf. The image attached).

drupwn

Fix (Fingerprinter.py line 26)

config["version"] = float(version.group(0)) by config["version"] = float(matched.group(0))

By the same token would you mind rebase your branch on the official repository ? Some changes have been applied recently.

Thanks again for your support.
Best,

@immunIT immunIT removed their assignment Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants