fix(web): use native image decoder #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This is probably still a nice thing to have, as the code is simpler and less likely to be prone to failures, but unfortunately does not resolve the linked issue.
|
uhthomas
force-pushed
the
3073
branch
5 times, most recently
from
177b6dc
to
485b326
Compare
jrasm91
approved these changes
Jul 2, 2023
jrasm91
approved these changes
Nov 29, 2023
martabal
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decode function should be more reliable than event listeners and doesn't need additional logic for destruction. The semantics of decode are also different to the 'load' event listener. 'decode' will wait until the image has been fully decoded and can be rendered, unlike 'load' which will trigger before the image has actually been decoded.
Fixes: #3073