Skip to content

fix: dev container properly builds @immich/plugin-sdk for import#28620

Merged
jrasm91 merged 1 commit into
immich-app:mainfrom
BlankCanvasStudio:sting-dev
May 27, 2026
Merged

fix: dev container properly builds @immich/plugin-sdk for import#28620
jrasm91 merged 1 commit into
immich-app:mainfrom
BlankCanvasStudio:sting-dev

Conversation

@BlankCanvasStudio
Copy link
Copy Markdown
Contributor

@BlankCanvasStudio BlankCanvasStudio commented May 25, 2026

Description

The dev containers do not start properly on fresh installs. They hang after the import of @immich/plugin-sdk and spin forever.

The build process doesn't expose this package for import via pnpm. There IS, however, some caching mechanism which prevents this bug from being reproducable on repos which have already called pnpm build @immich/plugin-sdk. This is most likely why the development team hasn't noticed.

Here's an example of the bug:

immich_server            | [10:56:03 PM] Starting compilation in watch mode...
immich_server            |
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...
immich_server            | src/dtos/workflow.dto.ts:1:41 - error TS2307: Cannot find module '@immich/plugin-sdk' or its corresponding type declarations.
immich_server            |
immich_server            | 1 import type { WorkflowStepConfig } from '@immich/plugin-sdk';
immich_server            |                                           ~~~~~~~~~~~~~~~~~~~~
immich_server            |
immich_server            | src/schema/tables/workflow-step.table.ts:1:36 - error TS2307: Cannot find module '@immich/plugin-sdk' or its corresponding type declarations.
immich_server            |
immich_server            | 1 import { WorkflowStepConfig } from '@immich/plugin-sdk';
immich_server            |                                      ~~~~~~~~~~~~~~~~~~~~
immich_server            |
immich_server            | src/services/workflow-execution.service.ts:2:92 - error TS2307: Cannot find module '@immich/plugin-sdk' or its corresponding type declarations.
immich_server            |
immich_server            | 2 import { WorkflowChanges, WorkflowEventData, WorkflowEventPayload, WorkflowResponse } from '@immich/plugin-sdk';
immich_server            |                                                                                              ~~~~~~~~~~~~~~~~~~~~
immich_server            |
immich_server            | src/services/workflow.service.ts:1:36 - error TS2307: Cannot find module '@immich/plugin-sdk' or its corresponding type declarations.
immich_server            |
immich_server            | 1 import { WorkflowStepConfig } from '@immich/plugin-sdk';
immich_server            |                                      ~~~~~~~~~~~~~~~~~~~~
immich_server            |
immich_server            | [10:57:24 PM] Found 4 errors. Watching for file changes.
immich_server            |
immich_web               | Waiting for http://immich-server:2283 to start...
immich_web               | Waiting for http://immich-server:2283 to start...

Fixes # (issue)

#28619

How Has This Been Tested?

The issue can be easily reproduced with:

git clone https://github.com/immich-app/immich
cd immich
make dev

Once the patch is applied, it can be easily fixed with:

git clone https://github.com/immich-app/immich
cd immich
make dev

Checklist:

  • I have carefully read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

N/A

@kvalev
Copy link
Copy Markdown
Contributor

kvalev commented May 26, 2026

Not only the dev container, but the normal make dev build is broken as well

@BlankCanvasStudio
Copy link
Copy Markdown
Contributor Author

@kvalev This patch also fixes the make dev build. That's how I stumbled onto this issue!

@jrasm91 jrasm91 merged commit 1a837a2 into immich-app:main May 27, 2026
65 of 66 checks passed
knom pushed a commit to knom/immich that referenced this pull request May 31, 2026
…ich-app#28620)

Co-authored-by: Spencer Stingley <accounts@blankcanvas.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants