fix: dev container properly builds @immich/plugin-sdk for import#28620
Merged
Conversation
4 tasks
Contributor
|
Not only the dev container, but the normal |
Contributor
Author
|
@kvalev This patch also fixes the |
jrasm91
approved these changes
May 27, 2026
knom
pushed a commit
to knom/immich
that referenced
this pull request
May 31, 2026
…ich-app#28620) Co-authored-by: Spencer Stingley <accounts@blankcanvas.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dev containers do not start properly on fresh installs. They hang after the import of
@immich/plugin-sdkand spin forever.The build process doesn't expose this package for import via pnpm. There IS, however, some caching mechanism which prevents this bug from being reproducable on repos which have already called
pnpm build @immich/plugin-sdk. This is most likely why the development team hasn't noticed.Here's an example of the bug:
Fixes # (issue)
#28619
How Has This Been Tested?
The issue can be easily reproduced with:
Once the patch is applied, it can be easily fixed with:
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
N/A