feat: use my.immich.app for externalDomain fallback #17209
Merged
+14
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably more useful than localhost.
bo0tzz
commented
Mar 29, 2025
| @@ -117,7 +117,7 @@ describe('/shared-links', () => { | |||
| const resp = await request(shareUrl).get(`/${linkWithAssets.key}`); | |||
| expect(resp.status).toBe(200); | |||
| expect(resp.header['content-type']).toContain('text/html'); | |||
| expect(resp.text).toContain(`<meta property="og:image" content="http://`); | |||
| expect(resp.text).toContain(`<meta property="og:image" content="https://my.immich.app`); | |||
There was a problem hiding this comment.
Is this the right thing to do here?
There was a problem hiding this comment.
It's weird but it's the correct test case, yes.
danieldietzler
approved these changes
Mar 30, 2025
zackpollard
approved these changes
Mar 31, 2025
kirill-dev-pro
pushed a commit
to kirill-dev-pro/immich-but-with-public-albums-within-instance
that referenced
this pull request
Apr 6, 2025
* feat: use my.immich.app for externalDomain fallback This is probably more useful than localhost. * chore: remove port param * fix: update expected value in tests * fix: update expected value in e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably more useful than localhost.