feat(mobile): backup albums search #16890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
approved these changes
Mar 17, 2025
|
@YarosMallorca I just remembered that I implemented this previously, and there were cases where albums didn't appear on this page. I didn't find the cause then, so this might surface some regression. Do you have any idea how that case could potentially happen? |
|
@alextran1502 Not really, unless it lazy-loads the albums for some reason... |
|
@YarosMallorca Yeah, I think it might be good to try testing with 50-75 local albums |
|
This page will be reworked to use the Sqlite DB. I'll close this for now. We can handle this in the rework or after. Thanks for working on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a search field on the "Backup Albums selection" page. Some users have many albums on their phones, this will make it easier for people to find the exact albums they want to select for backup.
Implements #13617
Screenshots (if appropriate)