fix: styling for last image in person grid #13444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is PR For Issue #13312 |
|
Hello, can you include a screenshot of before/after for the fix? |
bo0tzz
changed the title
jrasm91
reviewed
Oct 15, 2024
web/src/lib/components/faces-page/people-infinite-scroll.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Rasmussen <jason@rasm.me>
Before
After
The Last Person Container is coming inside the whole grid. |
jrasm91
approved these changes
Oct 16, 2024
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 16, 2024
* Add Display Content to LastPersonContainer Div * Update web/src/lib/components/faces-page/people-infinite-scroll.svelte Co-authored-by: Jason Rasmussen <jason@rasm.me> --------- Co-authored-by: manan <manan@manan.myguest.virtualbox.org> Co-authored-by: Jason Rasmussen <jason@rasm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13312
Added Display Contents to the line 26 of people-infinite-scroll.svelte
<div bind:this={lastPersonContainer} style="display: contents;">