Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/(web) Set the alias of zh-CN to zh-Hans #13412

Closed
wants to merge 1 commit into from
Closed

fix/(web) Set the alias of zh-CN to zh-Hans #13412

wants to merge 1 commit into from

Conversation

fa1seut0pia
Copy link
Contributor

fix browser does not display local settings Chinese. #13401

@github-actions GitHub Actions
Copy link
Contributor

Label error. Requires exactly 1 of: changelog:.*. Found:

danieldietzler
danieldietzler reviewed Oct 13, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not make sense to me. We already distinguish code and weblateCode in line 317 and 323 of the constants.ts file respectively. So clearly, weblate uses zh_SIMPLIFIED and not zh-Hans, and the browser uses zh-Hans, right?

@fa1seut0pia
Copy link
Contributor Author

No，browser uses zh-CN

image

@danieldietzler
Copy link
Member

I meant "browser" as in, the code immich uses in web.

@danieldietzler
Copy link
Member

Try setting code: 'zh-CN in line 323 and undo all your other changes.

@fa1seut0pia fa1seut0pia deleted the fix/web-set-the-alias-of-zh-CN-to-zh-Hans branch October 13, 2024 18:38
@fa1seut0pia fa1seut0pia restored the fix/web-set-the-alias-of-zh-CN-to-zh-Hans branch October 13, 2024 18:39
@fa1seut0pia fa1seut0pia mentioned this pull request Oct 13, 2024
Merged
@fa1seut0pia fa1seut0pia deleted the fix/web-set-the-alias-of-zh-CN-to-zh-Hans branch October 13, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler left review comments

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fa1seut0pia @danieldietzler