chore: fix tests

immich-app · Aug 14, 2024 · 5811c33 · 5811c33
1 parent 340bc0f
commit 5811c33
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/server/src/services/media.service.spec.ts b/server/src/services/media.service.spec.ts
@@ -297,6 +297,8 @@ describe(MediaService.name, () => {
         quality: 80,
         colorspace: Colorspace.SRGB,
         processInvalidImages: false,
+        angle: 0,
+        mirror: false,
       });
       expect(assetMock.update).toHaveBeenCalledWith({ id: 'asset-id', previewPath });
     });
@@ -328,6 +330,8 @@ describe(MediaService.name, () => {
           quality: 80,
           colorspace: Colorspace.P3,
           processInvalidImages: false,
+          angle: 0,
+          mirror: false,
         },
       );
       expect(assetMock.update).toHaveBeenCalledWith({
@@ -471,6 +475,8 @@ describe(MediaService.name, () => {
           quality: 80,
           colorspace: Colorspace.SRGB,
           processInvalidImages: false,
+          angle: 0,
+          mirror: false,
         });
         expect(assetMock.update).toHaveBeenCalledWith({ id: 'asset-id', thumbnailPath });
       },
@@ -502,6 +508,8 @@ describe(MediaService.name, () => {
         quality: 80,
         colorspace: Colorspace.P3,
         processInvalidImages: false,
+        angle: 0,
+        mirror: false,
       },
     );
     expect(assetMock.update).toHaveBeenCalledWith({
@@ -529,6 +537,8 @@ describe(MediaService.name, () => {
           quality: 80,
           colorspace: Colorspace.P3,
           processInvalidImages: false,
+          angle: 0,
+          mirror: false,
         },
       ],
     ]);
@@ -554,6 +564,8 @@ describe(MediaService.name, () => {
           quality: 80,
           colorspace: Colorspace.P3,
           processInvalidImages: false,
+          angle: 0,
+          mirror: false,
         },
       ],
     ]);
@@ -577,6 +589,8 @@ describe(MediaService.name, () => {
         quality: 80,
         colorspace: Colorspace.P3,
         processInvalidImages: false,
+        angle: 0,
+        mirror: false,
       },
     );
     expect(mediaMock.getImageDimensions).not.toHaveBeenCalled();
@@ -598,6 +612,8 @@ describe(MediaService.name, () => {
         quality: 80,
         colorspace: Colorspace.P3,
         processInvalidImages: false,
+        angle: 0,
+        mirror: false,
       },
     );
     expect(mediaMock.getImageDimensions).not.toHaveBeenCalled();
@@ -619,6 +635,8 @@ describe(MediaService.name, () => {
         quality: 80,
         colorspace: Colorspace.P3,
         processInvalidImages: true,
+        angle: 0,
+        mirror: false,
       },
     );
     expect(mediaMock.getImageDimensions).not.toHaveBeenCalled();

diff --git a/server/src/services/metadata.service.spec.ts b/server/src/services/metadata.service.spec.ts
@@ -934,6 +934,7 @@ describe(MetadataService.name, () => {
       const description = 'this is a description';
       const gps = 12;
       const date = '2023-11-22T04:56:12.196Z';
+      const orientation = 6;
 
       assetMock.getByIds.mockResolvedValue([assetStub.sidecar]);
       await expect(
@@ -943,6 +944,7 @@ describe(MetadataService.name, () => {
           latitude: gps,
           longitude: gps,
           dateTimeOriginal: date,
+          orientation: orientation.toString(),
         }),
       ).resolves.toBe(JobStatus.SUCCESS);
       expect(metadataMock.writeTags).toHaveBeenCalledWith(assetStub.sidecar.sidecarPath, {
@@ -951,6 +953,7 @@ describe(MetadataService.name, () => {
         DateTimeOriginal: date,
         GPSLatitude: gps,
         GPSLongitude: gps,
+        'Orientation#': orientation,
       });
     });
   });

diff --git a/server/src/services/metadata.service.ts b/server/src/services/metadata.service.ts
@@ -276,7 +276,7 @@ export class MetadataService implements OnEvents {
         DateTimeOriginal: dateTimeOriginal,
         GPSLatitude: latitude,
         GPSLongitude: longitude,
-        'Orientation#': Number.parseInt(orientation ?? '1', 10),
+        'Orientation#': _.isUndefined(orientation) ? undefined : Number.parseInt(orientation ?? '1', 10),
         Rating: rating,
       },
       _.isUndefined,