-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Logitech MX Ink model #266
Conversation
Tested with the latest Quest Browser version. Model position, orientation and button animation are correct (well, in fact, the button animations are a bit exaggerated to give a proper visual feedback, the buttons in the device barely move) Also, when testing I noticed both left and right handed models weren't linked to the |
Thank you! Checked out locally and verified that the buttons are indeed mapped as one would expect and that the mesh is showing up for left, right, and none handedness. I'll leave @cabanier to verify that the pose of the pen matches the physical device when held, but otherwise LGTM to merge! |
I just noticed the viewer report a pair of errors for missing nodes (they don't correspond to any moving part in the controller), and the "Preparing a WebXR input profile mesh" tutorial recommends to create empty nodes in the mesh to remove those errors. I am gonna add those, just in case. |
Nevermind previous now deleted comment, I just saw you already included the override. |
@ferminLR I pullled your model into my repo but I don't see any button animations.
|
I forgot to rebuild. This is looking great! lgtm |
@toji Can you push this to the CDN when you have a chance? |
Yeah, I'll see if I can get that out today. |
actually, can you wait? We might need some adjustment to the model. |
Added 3D model of the Logitech MX Ink stylus, with the correct position, orientation and the buttons animated.