Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logitech MX Ink model #266

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Update Logitech MX Ink model #266

merged 3 commits into from
Sep 11, 2024

Conversation

ferminLR
Copy link
Contributor

Added 3D model of the Logitech MX Ink stylus, with the correct position, orientation and the buttons animated.

@ferminLR
Copy link
Contributor Author

Tested with the latest Quest Browser version. Model position, orientation and button animation are correct (well, in fact, the button animations are a bit exaggerated to give a proper visual feedback, the buttons in the device barely move)

Also, when testing I noticed both left and right handed models weren't linked to the none.glb file. Now that is fixed.

@toji toji requested a review from cabanier September 11, 2024 22:08
@toji
Copy link
Member

toji commented Sep 11, 2024

Thank you! Checked out locally and verified that the buttons are indeed mapped as one would expect and that the mesh is showing up for left, right, and none handedness.

I'll leave @cabanier to verify that the pose of the pen matches the physical device when held, but otherwise LGTM to merge!

@ferminLR
Copy link
Contributor Author

I just noticed the viewer report a pair of errors for missing nodes (they don't correspond to any moving part in the controller), and the "Preparing a WebXR input profile mesh" tutorial recommends to create empty nodes in the mesh to remove those errors. I am gonna add those, just in case.

@AdaRoseCannon
Copy link
Member

Nevermind previous now deleted comment, I just saw you already included the override.

@cabanier
Copy link
Member

@ferminLR I pullled your model into my repo but I don't see any button animations.
I also see:

Could not find xr_standard_trigger_pressed_min in the model
Could not find xr_standard_squeeze_pressed_min in the model
Could not find tip_force_pressed_min in the model
Could not find docked_pressed_min in the model

@cabanier
Copy link
Member

cabanier commented Sep 11, 2024

@ferminLR I pullled your model into my repo but I don't see any button animations. I also see:

I forgot to rebuild. This is looking great! lgtm

@cabanier cabanier merged commit 63a1ed9 into immersive-web:main Sep 11, 2024
1 check failed
@cabanier
Copy link
Member

@toji Can you push this to the CDN when you have a chance?

@toji
Copy link
Member

toji commented Sep 12, 2024

Yeah, I'll see if I can get that out today.

@cabanier
Copy link
Member

Yeah, I'll see if I can get that out today.

actually, can you wait? We might need some adjustment to the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants