Skip to content

add exceptions when layer creation fails #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cabanier merged 2 commits into from
Sep 12, 2025
Merged

add exceptions when layer creation fails #316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e81c1a7
add exception when layer creation fails
cabanier Sep 11, 2025
247948f
address review comment
cabanier Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion webxrlayers-1.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,8 @@ The various layer types are created with the create____Layer series of methods o
such as whether or not to allocate a depth buffer or alpha channel, are passed in at layer creation time and will be immutable for the lifetime of the layer.
The method will return the associated XRCompositionLayer type.

Some layer types may not be supported by the {{XRSession}}. If a layer type isn't supported the method will throw an exception. {{XRProjectionLayer}} MUST be supported by all {{XRSession}}s.
If an {{XRSession}} was created with the "[=feature descriptor/layers=]" [=feature descriptor=], it MUST support all layer types.
If a layer type isn't supported its creation method MUST throw an exception. {{XRProjectionLayer}} MUST be supported by all {{XRSession}}s, whether it was created with the "[=feature descriptor/layers=]" [=feature descriptor=] or not.
</section>

Opaque textures {#xropaquetextures}
Expand Down Expand Up @@ -1229,19 +1230,22 @@ To <dfn>allocate color textures for projection layers</dfn> using an {{XRProject
<dt> If |textureType| is {{"texture-array"}}:
<dd> If the session’s [=view|views=] in the [=list of views=] don't all have the same [=recommended WebGL color texture resolution=] excluding the [=secondary view|secondary views=], throw a {{NotSupportedError}} and abort these steps.
<dd> Initialize |array| with 1 [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a {{TEXTURE_2D_ARRAY}} texture with |numViews| layers using |context|, |textureFormat|, |width| and |height|.
<dd> If the [=opaque texture=] was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
<dd> Return |array| and abort these steps.
<dt> Otherwise
<dd> For each |view| in the |session|'s [=list of views=]:
1. If |view| is a [=secondary view=], continue.
1. Let |width| be the width of |view|'s [=recommended WebGL color texture resolution=] multiplied by |scaleFactor|.
1. Let |height| be the height of |view|'s [=recommended WebGL color texture resolution=] multiplied by |scaleFactor|.
1. let |texture| be a [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a {{TEXTURE_2D}} texture with |context|, |textureFormat|, |width| and |height|.
1. If the |texture| was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
1. Append |texture| to |array|.
<dd> Return |array| and abort these steps.
</dl>
1. If the session’s [=view|views=] in the [=list of views=] don't all have the same [=recommended WebGL color texture resolution=] excluding the [=secondary view|secondary views=], throw a {{NotSupportedError}} and abort these steps.
1. If |layer|'s {{XRCompositionLayer/layout}} is {{XRLayerLayout/stereo-left-right}}, initialize |array| with 1 [=new=] instance of [=opaque texture=] in the [=relevant realm=] of |context| created as a |textureType| texture using |context| , |textureFormat|, |numViews| multiplied by |width| and |height|.
1. If |layer|'s {{XRCompositionLayer/layout}} is {{XRLayerLayout/stereo-top-bottom}}, initialize |array| with 1 [=new=] instance of [=opaque texture=] in the [=relevant realm=] of |context| created as a |textureType| texture using |context| , |textureFormat|, |width| and |numViews| multiplied by |height|.
1. If the [=opaque texture=] was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
1. return |array|.

</div>
Expand All @@ -1263,19 +1267,22 @@ To <dfn>allocate depth textures for projection layers</dfn> using an {{XRProject
<dl class="switch">
<dt> If |textureType| is {{"texture-array"}}:
<dd> Initialize |array| with 1 [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a {{TEXTURE_2D_ARRAY}} texture with |numViews| layers using |context|, |textureFormat|, |stencil|, |width| and |height|.
<dd> If the [=opaque texture=] was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
<dd> Return |array| and abort these steps.
<dt> Otherwise
<dd> For each |view| in the |session|'s [=list of views=]:
1. If |view| is a [=secondary view=], continue.
1. Let |width| be the width of |view|'s [=recommended WebGL depth texture resolution=] multiplied by |scaleFactor|.
1. Let |height| be the height of |view|'s [=recommended WebGL depth texture resolution=] multiplied by |scaleFactor|.
1. let |texture| be a [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a {{TEXTURE_2D}} texture with |context|, |textureFormat|, |stencil|, |width| and |height|.
1. If the |texture| was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
1. Append |texture| to |array|.
<dd> Return |array| and abort these steps.
</dl>
1. If the session’s [=view|views=] in the [=list of views=] don't all have the same [=recommended WebGL color texture resolution=] excluding the [=secondary view|secondary views=], throw a {{NotSupportedError}} and abort these steps.
1. If |layer|'s {{XRCompositionLayer/layout}} is {{XRLayerLayout/stereo-left-right}}, initialize |array| with 1 [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a |textureType| texture using |context|, |textureFormat|, |stencil|, |numViews| multiplied by |width| and |height|.
1. If |layer|'s {{XRCompositionLayer/layout}} is {{XRLayerLayout/stereo-top-bottom}}, initialize |array| with 1 [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a |textureType| texture using |context|, |textureFormat|, |stencil|, |width| and |numViews| multiplied by |height|.
1. If the [=opaque texture=] was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
1. return |array|.

</div>
Expand All @@ -1296,19 +1303,22 @@ To <dfn>allocate motion vector textures for projection layers</dfn> using an {{X
<dl class="switch">
<dt> If |textureType| is {{"texture-array"}}:
<dd> Initialize |array| with 1 [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a {{TEXTURE_2D_ARRAY}} texture with |numViews| layers using |context|, {{RGBA16F}}, |width| and |height|.
<dd> If the [=opaque texture=] was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
<dd> Return |array| and abort these steps.
<dt> Otherwise
<dd> For each |view| in the |session|'s [=list of views=]:
1. If |view| is a [=secondary view=], continue.
1. Let |width| be the width of |view|'s [=recommended motion vector texture resolution=] multiplied by |scaleFactor|.
1. Let |height| be the height of |view|'s [=recommended motion vector texture resolution=] multiplied by |scaleFactor|.
1. let |texture| be a [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a {{TEXTURE_2D}} texture with |context|, {{RGBA16F}}, |width| and |height|.
1. If the |texture| was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
1. Append |texture| to |array|.
<dd> Return |array| and abort these steps.
</dl>
1. If the session’s [=view|views=] in the [=list of views=] don't all have the same [=recommended motion vector texture resolution=] excluding the [=secondary view|secondary views=], throw a {{NotSupportedError}} and abort these steps.
1. If |layer|'s {{XRCompositionLayer/layout}} is {{XRLayerLayout/stereo-left-right}}, initialize |array| with 1 [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a |textureType| texture using |context|, {{RGBA16F}}, |numViews| multiplied by |width| and |height|.
1. If |layer|'s {{XRCompositionLayer/layout}} is {{XRLayerLayout/stereo-top-bottom}}, initialize |array| with 1 [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a |textureType| texture using |context|, {{RGBA16F}}, |width| and |numViews| multiplied by |height|.
1. If the [=opaque texture=] was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
1. return |array|.

</div>
Expand All @@ -1331,6 +1341,7 @@ To <dfn>allocate the color textures for the secondary views</dfn> using an {{XRP
<dt> Otherwise
<dd> Let |texture| be a [=new=] instance of an [=opaque texture=] in the [=relevant realm=] of |context| created as a {{TEXTURE_2D}} texture with |context|, |textureFormat|, |width| and |height|.
</dl>
1. If the |texture| was unable to be created for any reason, throw an {{OperationError}} and abort these steps.
1. Append |texture| to |array|.
1. Return |array| and abort these steps.

Expand Down