In 6.0.3 flow types for enableAllPlugins() etc. don't exist in index.js.flow #570
Labels
Comments
|
PR welcome!
…On Thu, Apr 2, 2020 at 3:06 PM Steven Watanabe ***@***.***> wrote:
🐛 Bug Report
Starting with ***@***.***, flow reports an error when trying to import
the immer functions from
https://immerjs.github.io/immer/docs/installation#pick-your-immer-version
To Reproduce
Minimal test file:
// @flow
import {enableAllPlugins} from 'immer';
enableAllPlugins();
Then run flow type checking.
Observed behavior
Flow reports the error:
Cannot import enableAllPlugins because there is no enableAllPlugins export in immer.
Expected behavior
No flow errors.
Environment
- ***@***.***
- flow
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#570>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBC77KGCXYJFFZUI2KLRKSLXHANCNFSM4L2PI4OA>
.
|
|
I suspect this is showing up in 6.0.3 because flow is now actually using the type definitions from this change. Before that flow would treat |
|
@watanas do you want to put a pull request for this together. I just ran into this as well and would love to get updated flow types in. If not, I'd be happy to work on it. |
|
@esturcke Added a pull request for this issue. PTAL. Thanks! |
|
🎉 This issue has been resolved in version 6.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
Starting with immer@6.0.3, flow reports an error when trying to import the immer functions from
https://immerjs.github.io/immer/docs/installation#pick-your-immer-version
To Reproduce
Minimal test file:
Then run flow type checking.
Observed behavior
Flow reports the error:
Expected behavior
No flow errors.
Environment
The text was updated successfully, but these errors were encountered: