fix: protect isDraftable against undefined constructor (#969)

* protect against undefined constructor * add test case
immerjs · Oct 22, 2022 · ced4563 · ced4563
1 parent 078e523
commit ced4563
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/__tests__/isDraftable.js b/__tests__/isDraftable.js
@@ -0,0 +1,7 @@
+"use strict"
+import { isDraftable } from "../src/immer"
+
+test("non-plain object with undefined constructor doesn't error", () => {
+    const obj = Object.create(Object.create(null))
+    expect(isDraftable(obj).toBe(true);
+})
diff --git a/src/utils/common.ts b/src/utils/common.ts
@@ -27,7 +27,7 @@ export function isDraftable(value: any): boolean {
 		isPlainObject(value) ||
 		Array.isArray(value) ||
 		!!value[DRAFTABLE] ||
-		!!value.constructor[DRAFTABLE] ||
+		!!value.constructor?.[DRAFTABLE] ||
 		isMap(value) ||
 		isSet(value)
 	)