Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for OPENSLIDE and TURBOJPEG env variables #7

Open
jesper-molin opened this issue Dec 2, 2021 · 1 comment
Open

Remove need for OPENSLIDE and TURBOJPEG env variables #7

jesper-molin opened this issue Dec 2, 2021 · 1 comment

Comments

@jesper-molin
Copy link
Collaborator

jesper-molin commented Dec 2, 2021

I think it is complicated for an end user to get the right versions and set environment variables.

So I think we should find a reasonable way to ship openslide and turbojpeg binaries with the packaging, so they don't have to be installed manually and pointing them out using environment variables.

Dockerhub is one way to do it, but will still be unfamiliar for most people. I think the best solution would be pip dealt with it.

There are two options as I understand it. Either you ship it with the wheel package, I know shapely (https://github.com/Toblerity/Shapely) moved from not including the DLL to doing so. Or if the DLLs are too big or the license does not allow shipping the DLLs, there is also the possibility to have a script that fetches the DLL during install.

@sarthakpati
Copy link

I would also add that openslide is not particularly important/useful for pythonic environments. It would be better to use something like tiffslide in its stead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants