Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenSlide as a dependency #60

Closed
sarthakpati opened this issue Mar 22, 2023 · 4 comments
Closed

Remove OpenSlide as a dependency #60

sarthakpati opened this issue Mar 22, 2023 · 4 comments

Comments

@sarthakpati
Copy link

          I would also add that openslide is not particularly important/useful for pythonic environments. It would be better to use something like tiffslide in its stead.

Originally posted by @sarthakpati in #7 (comment)

@erikogabrielsson
Copy link
Collaborator

For now openslide is needed to support mirax files. Tiffslide has a work in progress to support mirax, but until it does openslide should be kept.

However, adding support for reading from tiffslide might be worth implementing earlier, as for example the fsspec support. Im currently refactoring how wsis are opened (starting in wsidicom), but can do a simple implementation after that.

@sarthakpati
Copy link
Author

Awesome! It would be great if you could at least put openslide import as a try-except for files that tiffslide does not currently support. This would not break the functionality of wsidicomizer, as well as ensure that when tiffslide's file support increases, it would be trivial to remove the openslide components. What do you think?

@erikogabrielsson
Copy link
Collaborator

Yes openslide will be moved to an extra-category.

@erikogabrielsson
Copy link
Collaborator

Closed with #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants