Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MT2 Improvements #533

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

1Revenger1
Copy link

This PR brings improvements to the MT2 in both USB and BT mode.

  • (#b15c782) Tip Switch is set based off of state bits sent out by the MT2, which distinguishes between contacts and near field fingers.
    • Reduces errors from hovering fingers, such as directly after scrolling or three finger gestures
  • (#ec3adee) Timestamp is replaced with the timestamp given in the reports as well.
  • (#7e3d1d2) Check report IDs on incoming reports and retrieve next input report when an unknown report is received. The MT2 over BT will send input reports with battery percentage or other information. Receiving these reports without queuing to receive another input report can brick the touchpad until the driver is reset.

These changes should also be somewhat portable to other touchpad variants. The state bits are sent out by every trackpad variant, including those that do not report pressure (such as my MacbookPro9,2). I do not have windows on my MBP9,2, so have no way to test a driver variant with these state bits.

I separated out the changes into different commits, so feel free to cherry pick whichever ones you want.

@youdonghai
Copy link

Hi 1Revenger1, could you create a release package from your PR for everyone to use?

@1Revenger1
Copy link
Author

Unfortunately not. I do not have the resources necessary to sign a release.

@vitoplantamura
Copy link

hey, thanks for this PR.

Your work inspired me to create a "more complete" version of the imbushuo driver, with a Control Panel, haptic feedback control and more options to increase pointer precision:

https://github.com/vitoplantamura/MagicTrackpad2ForWindows

Thanks, Vito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants