fix inefficient regular expressions on lowercase and uppercase rules

imbrn · Jul 1, 2022 · 9239386 · 9239386
1 parent 472b06b
commit 9239386
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/v8n.js b/src/v8n.js
@@ -189,9 +189,15 @@ const availableRules = {
 
   pattern: expected => value => expected.test(value),
 
-  lowercase: () => value => /^([a-z]+\s*)+$/.test(value),
+  lowercase: () => value => {
+    return (
+      typeof value === 'boolean' ||
+      (value === value.toLowerCase() && value.trim() !== '')
+    );
+  },
 
-  uppercase: () => value => /^([A-Z]+\s*)+$/.test(value),
+  uppercase: () => value =>
+    value === value.toUpperCase() && value.trim() !== '',
 
   vowel: () => value => /^[aeiou]+$/i.test(value),