Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
This PR contains multiple changes.
@JvmOverloads
on some functions for better Java compatibility📄 Motivation and Context
I've made those changes because it was not nice to use with unnecessary get methods and depending on LiveData as it's not flexible enough for my usecase.
Additionally I could not pass the layout inside the Fragment constructor what I normally do #14.
🧪 How Has This Been Tested?
I've tested it using an emulator, opend every activity and navigated further (e.g. next activity or next fragment).
No crash occurred and it works as expected.
📦 Types of changes
Bug fix (non-breaking change which fixes an issue)
Fixed memory leaks
New feature (non-breaking change which adds functionality)
Pass layout in Fragment constructor and overload functions for Java
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Replaced LiveData with Flow and replaced some methods with variables
ThemeManager is an object now what means no
instance
call on it✅ Checklist