-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove network request for pngquant src #80
Remove network request for pngquant src #80
Conversation
867c507
to
85248f5
Compare
127786d
to
3ab1a7d
Compare
@sindresorhus Any thoughts? |
@sindresorhus Is this still maintained? |
You committed a change to |
I think this is a good idea 👍 |
You also need to add it to the |
79972f3
to
a0cd8c4
Compare
@sindresorhus I've made the requested changes. Thank you for reviewing! |
package.json
Outdated
@@ -33,7 +33,8 @@ | |||
"files": [ | |||
"cli.js", | |||
"index.js", | |||
"lib" | |||
"lib", | |||
"vendor/src-pngquant/pngquant-2.10.1-src.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just add vendor/src-pngquant
? One less place to change when updating to a newer version.
Problem
CI servers can sometimes fail to fetch the required bins and/or pngquant src.
Solution
binBuild.file
instead ofbinBuild.src