Fix icon loading

src/napari_imagej/widgets/result_tree.py

@@ -4,6 +4,8 @@
 SearchResults are grouped by the SciJava Searcher that created them.
 """
 
+from __future__ import annotations
+
 from typing import Dict, List
 
 from qtpy.QtCore import Qt, Signal
@@ -13,7 +15,7 @@
 
 from napari_imagej.java import ij, jc
 from napari_imagej.utilities.logging import log_debug
-from napari_imagej.widgets.widget_utils import _getIcon, python_actions_for
+from napari_imagej.widgets.widget_utils import _get_icon, python_actions_for
 
 
 class SearcherTreeView(QTreeView):
@@ -106,7 +108,7 @@ def __init__(self, result: "jc.SearchResult"):
 
         # Set QtPy properties
         self.setEditable(False)
-        if icon := _getIcon(result.iconPath()):
+        if icon := _get_icon(str(result.iconPath()), result.getClass()):
             self.setIcon(icon)
 
 

src/napari_imagej/widgets/widget_utils.py

@@ -295,26 +295,32 @@ def pass_to_ij():
 
 
 @lru_cache
-def _getIcon(icon_path):
+def _get_icon(path: str, cls: "jc.Class" = None):
     # Ignore falsy paths
-    if not icon_path:
+    if not path:
         return
-    stream = jc.File.class_.getResourceAsStream(icon_path)
-    # Ignore falsy streams
-    if not stream:
+    # Web URLs
+    if path.startswith("https"):
+        # TODO: Add icons from web
         return
-    # Create a buffer to create the byte[]
-    buffer = jc.ByteArrayOutputStream()
-    foo = JArray(JByte)(1024)
-    while True:
-        length = stream.read(foo, 0, foo.length)
-        if length == -1:
-            break
-        buffer.write(foo, 0, length)
-    # Convert the byte[] into a bytearray
-    bytes_array = bytearray()
-    bytes_array.extend(buffer.toByteArray())
-    # Convert thte bytearray into a QIcon
-    pixmap = QPixmap()
-    pixmap.loadFromData(QByteArray(bytes_array))
-    return QIcon(pixmap)
+    # Java Resources
+    elif isinstance(cls, jc.Class):
+        stream = cls.getResourceAsStream(path)
+        # Ignore falsy streams
+        if not stream:
+            return
+        # Create a buffer to create the byte[]
+        buffer = jc.ByteArrayOutputStream()
+        foo = JArray(JByte)(1024)
+        while True:
+            length = stream.read(foo, 0, foo.length)
+            if length == -1:
+                break
+            buffer.write(foo, 0, length)
+        # Convert the byte[] into a bytearray
+        bytes_array = bytearray()
+        bytes_array.extend(buffer.toByteArray())
+        # Convert thte bytearray into a QIcon
+        pixmap = QPixmap()
+        pixmap.loadFromData(QByteArray(bytes_array))
+        return QIcon(pixmap)

tests/utils.py

@@ -181,6 +181,9 @@ def info(self):
     def iconPath(self):
         return None
 
+    def getClass(self):
+        return None
+
 
 class DummyModuleInfo:
     """