Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
write_framesformatted ffmpeg's input-rwith{:.02f}, so rateslike NTSC film (
24000/1001≈ 23.976) were sent as-r 23.98. Thatchanges the file timebase (e.g.
19184 tbninstead of24k tbn) andcan desync audio and subtitles. ffmpeg's
-ralready accepts afraction; this PR passes one.
Decision
str(Fraction(fps).limit_denominator())as the-rvalue.str(fps)).exact NTSC rationals from the corresponding float (
24000/1001stays24000/1001; integer16becomes16). Happy to switch to a decimalif a rational on the command line is unwelcome.
Integer defaults therefore go out as
-r 16rather than-r 16.00.Same rate for ffmpeg.
input_params=['-r', ...]still overrides bycoming later on the command line.
Not in this PR: exact fps when reading. ffmpeg's banner still prints
two decimals, and this project does not ship ffprobe (the reporter
noted that; left as an acknowledged limitation).
Test plan
test_write_fps_precisionfails with the old{:.02f}(-r 23.98)and passes with the rational (
24000/1001)Fixes #116