Skip to content

keep only 1 laplacian for simplicity #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

keep only 1 laplacian for simplicity #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/filter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,14 +440,14 @@ where
/// ```
#[must_use = "the function does not modify the original image"]
pub fn laplacian_filter(image: &GrayImage) -> Image<Luma<i16>> {
filter_clamped(image, kernel::FOUR_LAPLACIAN_3X3)
filter_clamped(image, kernel::LAPLACIAN_3X3)
}

#[must_use = "the function does not modify the original image"]
#[cfg(feature = "rayon")]
#[doc = generate_parallel_doc_comment!("laplacian_filter")]
pub fn laplacian_filter_parallel(image: &GrayImage) -> Image<Luma<i16>> {
filter_clamped_parallel(image, kernel::FOUR_LAPLACIAN_3X3)
filter_clamped_parallel(image, kernel::LAPLACIAN_3X3)
}

#[cfg(test)]
Expand Down
8 changes: 2 additions & 6 deletions src/kernel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,5 @@ pub const ROBERTS_HORIZONTAL_2X2: Kernel<'static, i32> = Kernel::new(&[1, 0, 0,
/// The roberts vertical 3x3 kernel.
pub const ROBERTS_VERTICAL_2X2: Kernel<'static, i32> = Kernel::new(&[0, 1, -1, -0], 2, 2);

/// The 4-connectivity laplacian 3x3 kernel.
pub const FOUR_LAPLACIAN_3X3: Kernel<'static, i16> =
Kernel::new(&[0, 1, 0, 1, -4, 1, 0, 1, 0], 3, 3);
/// The 8-connectivity laplacian 3x3 kernel.
pub const EIGHT_LAPLACIAN_3X3: Kernel<'static, i16> =
Kernel::new(&[1, 1, 1, 1, -8, 1, 1, 1, 1], 3, 3);
/// The laplacian 3x3 kernel.
pub const LAPLACIAN_3X3: Kernel<'static, i16> = Kernel::new(&[0, 1, 0, 1, -4, 1, 0, 1, 0], 3, 3);
Loading