Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoredOnlyCompressor feature is here, and we can now access it. #490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arichnad
Copy link

@arichnad arichnad commented Jul 29, 2024

StoredOnlyCompressor feature is here, and we can now access it:

Why

Creating a png with Compression::None makes file creation much faster than Compression::Fast.

For hard to compress images, file size between Compression::None and Compression::Fast is is similar.

Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking extension to the enumeration but this is good. Just need to bump the version for the next release, I suppose. Let me check if a point-release should be done before merging.

src/encoder.rs Outdated Show resolved Hide resolved
@arichnad
Copy link
Author

arichnad commented Sep 18, 2024

I've addressed one of your comments and rebased onto master. Thanks @fintelia and @HeroicKatora !

@fintelia
Copy link
Contributor

Looks good. We'll just want to hold off merging until we've gotten out a minor release with all the non-breaking changes we want to lank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants