Skip to content

Conversation

@danielle-casella-adams
Copy link
Contributor

Summary of PR changes

  • In the increment-version-on-merge workflow switch to using the pull_request_target so when it is merged it will have the correct permissions to create and push a new version tag on the repo.
  • The descriptions of pull_request/pull_request_target have been updated so reviewers should know which scenarios each should be used in the workflows.
  • The version of the action has not been updated on the readme's since this change won't affect the usage.
    • When I have some time to implement the readme version update on merge all of the versions should be reconciled.

Copy link
Collaborator

@jsclifford jsclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsclifford jsclifford merged commit ef22cc3 into main Mar 21, 2022
@jsclifford jsclifford deleted the pr-target branch March 21, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants