[codex] Sync embedded computer-use-linux v0.2.5 - #419
Conversation
|
One suggestion before merging: can we make the new window-targeted click path fail closed where we already can verify the target?
I think The screenshot payload changes look fine to me; this is mostly about input safety. |
|
@avifenesh With the current layout, the backend is in the workspace, CI builds it, Nix sees it, native packages include it, and updater rebuilds use the same source. If it moves out, we need pinned versions/checksums, reproducible Nix builds, CI coverage for the exact shipped backend, native package integration, updater rebuild consistency, and no accidental dependency on a moving external release. So the main requirement would be: keep it fully pinned and reproducible. Otherwise the embedded workspace copy is fine as-is. |
| // Raise the target window first (if specified) so the click lands on the | ||
| // intended app rather than whatever is stacked on top at that pixel. | ||
| if let Some(target) = params.window_target() { | ||
| let _ = focus_window_target(&target).await; |
There was a problem hiding this comment.
This is an auto review done by revuto.
Targeted clicks should fail closed here. focus_window_target can return an error or a focus result that does not satisfy the requested target (the keyboard paths handle this via focus_target_for_input/focus_satisfies_target), but this call discards that result and still proceeds to send the click. In the same block, relative=true bounds resolution is best-effort, so if listing/resolution/bounds are unavailable the original x/y are sent as absolute desktop coordinates. For this destructive tool that can click the currently focused or occluding window instead of the requested target; please require verified focus, and require resolved bounds before translating relative clicks.
Summary
codex-computer-use-linuxto the standalonecomputer-use-linuxv0.2.5 screenshot payload behaviorget_app_state/screenshotTracks agent-sh/computer-use-linux#19.
Validation
cargo fmt --check -p codex-computer-use-linuxcargo check -p codex-computer-use-linux --all-targetscargo test -p codex-computer-use-linuxcargo clippy -p codex-computer-use-linux --all-targets -- -D warningsnode --test linux-features/agent-workspace/test.jscargo build -p codex-computer-use-linuxnode /home/avifenesh/projects/computer-use-linux/scripts/zod-check/check.mjs --command target/debug/codex-computer-use-linuxcargo check --workspace --all-targetscargo test --workspace --all-targetsgit diff --check