Skip to content

[codex] Keep Linux Chrome plugin available - #418

Merged
ilysenko merged 2 commits into
ilysenko:mainfrom
colonelpanic8:codex/fix-linux-chrome-plugin
Jun 5, 2026
Merged

[codex] Keep Linux Chrome plugin available#418
ilysenko merged 2 commits into
ilysenko:mainfrom
colonelpanic8:codex/fix-linux-chrome-plugin

Conversation

@colonelpanic8

Copy link
Copy Markdown
Contributor

Summary

  • Keep the bundled Chrome plugin available on Linux even when upstream externalBrowserUseAllowed is false.
  • Preserve upstream Chrome availability gating on non-Linux platforms.
  • Add regression coverage for the auto-installed Chrome gate and idempotent Linux-enabled gates.

Root Cause

The Linux launcher staged the Chrome plugin resources and native host, but the app's bundled-plugin marketplace resolver still filtered Chrome out when upstream externalBrowserUseAllowed was false. That left only computer-use in the runtime marketplace, causing Chrome to be uninstalled and its native host manifest to be removed.

Validation

  • node --test scripts/patch-linux-window-ui.test.js
  • bash -n install.sh scripts/lib/*.sh launcher/start.sh.template scripts/build-deb.sh scripts/build-rpm.sh scripts/build-pacman.sh scripts/build-appimage.sh
  • Locally verified the patched gate against the installed ASAR shape before rebasing.
  • Previously built nix build .#codex-desktop-computer-use-ui-remote-mobile-control successfully with the patch.

@ilysenko
ilysenko marked this pull request as ready for review June 5, 2026 19:15

@ilysenko ilysenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head c8aa876; checks pass.

@ilysenko
ilysenko merged commit 785216e into ilysenko:main Jun 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants